mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[GH-ISSUE #52] Build without dns_sd.h when not building GUI #42
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#42
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xantoz on GitHub (May 29, 2018).
Original GitHub issue: https://github.com/debauchee/barrier/issues/52
Operating Systems
Gentoo Linux
Barrier Version
2.1.0
Steps to reproduce bug
If I do not have any provider of dns_sd.h installed (such as mdnsresponder or avahi with mdnsrespondercompat) cmake aborts with: "Missing header: dns_sd.h"
Expected result: cmake will succeed as long as BARRIER_BUILD_GUI=OFF, despite the lack of a provider of dns_sd.h on my system. With BARRIER_BUILD_GUI=ON cmake will complain about missing dns_sd.h
Other info
The only files that include dns_sd.h are under src/gui/src, thus it seems that dns_sd is only a requirement when building the GUI. This also reflects the state of things for old versions of synergy.
Further I ended up installing avahi and building with GUI and I checked the output of ldd on the resulting binaries:
barrier-ldd.txt
Only the GUI executable "barrier" shows any dependency on libdns_sd.so.1, libavahi-client.so.3 and libavahi-common.so.3
@AdrianKoshka commented on GitHub (May 29, 2018):
I could be wrong, but I think barrier needs
dns_sd.hwhether you're building the GUI or not.@xantoz commented on GitHub (May 30, 2018):
synergy-1.9 doesn't, and judging from the barrier source code and the resulting binaries it shouldn't need it as well.
@walker0643 commented on GitHub (Jun 30, 2018):
You're absolutely right, @xantoz :) fixed in
e88bc97e63