mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[GH-ISSUE #354] Installer build currently fails on Azure Pipelines #284
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#284
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nelsonjchen on GitHub (Jul 6, 2019).
Original GitHub issue: https://github.com/debauchee/barrier/issues/354
@nelsonjchen any idea why the debug build would work, but not the release build? (Seems it can't find a file/folder https://dev.azure.com/debauchee/Barrier/_build/results?buildId=28)
Originally posted by @AdrianKoshka in https://github.com/debauchee/barrier/pull/352#issuecomment-508861147
Odd, my work started after the Wix change. I'm not sure what changed. Azure Pipelines does include Inno Setup in their images:
https://github.com/microsoft/azure-pipelines-image-generation/pull/313
@noisyshape commented on GitHub (Jul 8, 2019):
The failure is on the Build Installer step. Based on the output it looks like
C:\Program Files (x86)\Inno Setup 5\ISCC.exedoesn't exist. I think if the problem was anything else there would be a different error message.@nelsonjchen commented on GitHub (Jul 9, 2019):
They certainly don't pin it in their scripts to build the base image.
53f1ce1d90/images/win/scripts/Installers/Install-InnoSetup.ps1@nelsonjchen commented on GitHub (Jul 9, 2019):
Yep.
6@nelsonjchen commented on GitHub (Jul 9, 2019):
The tests Microsoft has to validate their image just checks if
iscc.exeis in the path:https://github.com/microsoft/azure-pipelines-image-generation/pull/327/files
I know we're on a bit of a moving platform but major version bumps aren't fun. Hmm. I'll see if I can get this to pin.
@nelsonjchen commented on GitHub (Jul 9, 2019):
Safest by pinning Inno Setup 5: https://github.com/debauchee/barrier/pull/356
I think we should merge the above soon. It's safe and reasonable for now.
Later by changing to Inno Setup 6 and building with that: https://github.com/debauchee/barrier/pull/357
I haven't tested this yet.
@AdrianKoshka commented on GitHub (Jul 9, 2019):
Seems the build still failed even when #356 was merged.
@nelsonjchen commented on GitHub (Jul 9, 2019):
Ah yeah that PR needs to be rebased or have master merged into it.
@AdrianKoshka commented on GitHub (Jul 9, 2019):
Ah, thanks. :D
@nelsonjchen commented on GitHub (Jul 9, 2019):
Looks to be resolved.