[PR #292] [MERGED] Rename the "Apply" button to "Reload" #1594

New issue

Closed

opened 2026-05-05 07:57:14 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:57:14 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/292
Author: @mssalvatore
Created: 4/18/2019
Status: ✅ Merged
Merged: 5/14/2019
Merged by: @AdrianKoshka

Base: master ← Head: issue_284

📝 Commits (1)

c544247 Rename the "Apply" button to "Reload"

📊 Changes

95 files changed (+55 additions, -55 deletions)

View changed files

📝 src/gui/gui.ts (+1 -1)
📝 src/gui/res/lang/gui_af-ZA.qm (+0 -0)
📝 src/gui/res/lang/gui_af-ZA.ts (+1 -1)
📝 src/gui/res/lang/gui_ar.qm (+0 -0)
📝 src/gui/res/lang/gui_ar.ts (+1 -1)
📝 src/gui/res/lang/gui_bg-BG.qm (+0 -0)
📝 src/gui/res/lang/gui_bg-BG.ts (+1 -1)
📝 src/gui/res/lang/gui_ca-AD.qm (+0 -0)
📝 src/gui/res/lang/gui_ca-AD.ts (+1 -1)
📝 src/gui/res/lang/gui_cs-CZ.qm (+0 -0)
📝 src/gui/res/lang/gui_cs-CZ.ts (+1 -1)
📝 src/gui/res/lang/gui_cy.qm (+0 -0)
📝 src/gui/res/lang/gui_cy.ts (+1 -1)
📝 src/gui/res/lang/gui_da.qm (+0 -0)
📝 src/gui/res/lang/gui_da.ts (+1 -1)
📝 src/gui/res/lang/gui_de.qm (+0 -0)
📝 src/gui/res/lang/gui_de.ts (+1 -1)
📝 src/gui/res/lang/gui_es.qm (+0 -0)
📝 src/gui/res/lang/gui_es.ts (+2 -2)
📝 src/gui/res/lang/gui_et-EE.qm (+0 -0)

...and 75 more files

📄 Description

The "Apply" button in the main window calls stopBarrier() immediately
followed by startBarrier(). The startBarrier() function reloads the
configuration. The fact that the "Apply" button applies configuration
changes is incidental; the "Start" button also applies new settings.

"Reload" more accurately describes the function that the button
performs.

Issue #284

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/292 **Author:** [@mssalvatore](https://github.com/mssalvatore) **Created:** 4/18/2019 **Status:** ✅ Merged **Merged:** 5/14/2019 **Merged by:** [@AdrianKoshka](https://github.com/AdrianKoshka) **Base:** `master` ← **Head:** `issue_284` --- ### 📝 Commits (1) - [`c544247`](https://github.com/debauchee/barrier/commit/c54424794f5779788d8bf0c88c8123a287ee39c8) Rename the "Apply" button to "Reload" ### 📊 Changes **95 files changed** (+55 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/gui.ts` (+1 -1) 📝 `src/gui/res/lang/gui_af-ZA.qm` (+0 -0) 📝 `src/gui/res/lang/gui_af-ZA.ts` (+1 -1) 📝 `src/gui/res/lang/gui_ar.qm` (+0 -0) 📝 `src/gui/res/lang/gui_ar.ts` (+1 -1) 📝 `src/gui/res/lang/gui_bg-BG.qm` (+0 -0) 📝 `src/gui/res/lang/gui_bg-BG.ts` (+1 -1) 📝 `src/gui/res/lang/gui_ca-AD.qm` (+0 -0) 📝 `src/gui/res/lang/gui_ca-AD.ts` (+1 -1) 📝 `src/gui/res/lang/gui_cs-CZ.qm` (+0 -0) 📝 `src/gui/res/lang/gui_cs-CZ.ts` (+1 -1) 📝 `src/gui/res/lang/gui_cy.qm` (+0 -0) 📝 `src/gui/res/lang/gui_cy.ts` (+1 -1) 📝 `src/gui/res/lang/gui_da.qm` (+0 -0) 📝 `src/gui/res/lang/gui_da.ts` (+1 -1) 📝 `src/gui/res/lang/gui_de.qm` (+0 -0) 📝 `src/gui/res/lang/gui_de.ts` (+1 -1) 📝 `src/gui/res/lang/gui_es.qm` (+0 -0) 📝 `src/gui/res/lang/gui_es.ts` (+2 -2) 📝 `src/gui/res/lang/gui_et-EE.qm` (+0 -0) _...and 75 more files_ </details> ### 📄 Description The "Apply" button in the main window calls stopBarrier() immediately followed by startBarrier(). The startBarrier() function reloads the configuration. The fact that the "Apply" button applies configuration changes is incidental; the "Start" button also applies new settings. "Reload" more accurately describes the function that the button performs. Issue #284 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>