[PR #969] [MERGED] Improvements to custom profile dir option #1723

Closed
opened 2026-05-05 08:00:20 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/969
Author: @albertony
Created: 12/5/2020
Status: Merged
Merged: 12/9/2020
Merged by: @p12tic

Base: masterHead: profile_dir


📝 Commits (2)

  • 01a78a4 Do not store path to ImmuneKeys.txt before --profile-dir is considered
  • 87c5f87 Include --profile-dir in help text

📊 Changes

3 files changed (+14 additions, -8 deletions)

View changed files

📝 src/lib/barrier/App.h (+2 -2)
📝 src/lib/barrier/ServerApp.cpp (+7 -1)
📝 src/lib/platform/MSWindowsHook.cpp (+5 -5)

📄 Description

Included --profile-dir in help text, output from barriers --help and barrierc --help.
If --profile-dir <path> is included first, then the given path will be used in the help text describing default path to configuration file.

Also fixed an issue where the full path to ImmuneKeys.txt were stored in a global variable before considering --profile-dir argument, so it would always be loaded from default %LocalAppData%\Barrier directory.

Related to https://github.com/debauchee/barrier/issues/961#issuecomment-739028515


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/969 **Author:** [@albertony](https://github.com/albertony) **Created:** 12/5/2020 **Status:** ✅ Merged **Merged:** 12/9/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `profile_dir` --- ### 📝 Commits (2) - [`01a78a4`](https://github.com/debauchee/barrier/commit/01a78a4d3aa58fc3cadf8cc17a112421e730e3b0) Do not store path to ImmuneKeys.txt before --profile-dir is considered - [`87c5f87`](https://github.com/debauchee/barrier/commit/87c5f874e45948ea621eae9d9d895c894dc6807c) Include --profile-dir in help text ### 📊 Changes **3 files changed** (+14 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/App.h` (+2 -2) 📝 `src/lib/barrier/ServerApp.cpp` (+7 -1) 📝 `src/lib/platform/MSWindowsHook.cpp` (+5 -5) </details> ### 📄 Description Included --profile-dir in help text, output from `barriers --help` and `barrierc --help`. If `--profile-dir <path>` is included first, then the given path will be used in the help text describing default path to configuration file. Also fixed an issue where the full path to ImmuneKeys.txt were stored in a global variable before considering `--profile-dir` argument, so it would always be loaded from default `%LocalAppData%\Barrier` directory. Related to https://github.com/debauchee/barrier/issues/961#issuecomment-739028515 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 08:00:20 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1723
No description provided.