[PR #915] [MERGED] Fixed gui writing invalid config for hotkeys with multiple actions #1718

New issue

Closed

opened 2026-05-05 08:00:11 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:11 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/915
Author: @dustinlieu
Created: 10/16/2020
Status: ✅ Merged
Merged: 1/10/2021
Merged by: @p12tic

Base: master ← Head: master

📝 Commits (1)

adc49fa gui: Fix invalid config being written for hotkeys with multiple actions

📊 Changes

2 files changed (+15 additions, -3 deletions)

View changed files

📝 src/gui/src/Hotkey.cpp (+14 -2)
📝 src/gui/test/HotkeyTests.cpp (+1 -1)

📄 Description

Hotkeys with multiple actions need to be separated by commas, not new lines, otherwise only one of the actions will be performed when the hotkey is pressed.

Works:

keystroke(Control+Alt+F11) = switchToScreen(Laptop), lockCursorToScreen(on)

Doesn't work:

keystroke(Control+Alt+F11) = switchToScreen(Laptop)
keystroke(Control+Alt+F11) = lockCursorToScreen(on)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/915 **Author:** [@dustinlieu](https://github.com/dustinlieu) **Created:** 10/16/2020 **Status:** ✅ Merged **Merged:** 1/10/2021 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`adc49fa`](https://github.com/debauchee/barrier/commit/adc49fa066030ca28b47e8690d6a8c8784ebb861) gui: Fix invalid config being written for hotkeys with multiple actions ### 📊 Changes **2 files changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/gui/src/Hotkey.cpp` (+14 -2) 📝 `src/gui/test/HotkeyTests.cpp` (+1 -1) </details> ### 📄 Description Hotkeys with multiple actions need to be separated by commas, not new lines, otherwise only one of the actions will be performed when the hotkey is pressed. Works: ``` keystroke(Control+Alt+F11) = switchToScreen(Laptop), lockCursorToScreen(on) ``` Doesn't work: ``` keystroke(Control+Alt+F11) = switchToScreen(Laptop) keystroke(Control+Alt+F11) = lockCursorToScreen(on) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>