[PR #818] [MERGED] Add key entries for Eisu_toggle and Muhenkan #1702

Closed
opened 2026-05-05 07:59:50 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/818
Author: @tom-tan
Created: 7/27/2020
Status: Merged
Merged: 8/7/2020
Merged by: @p12tic

Base: masterHead: add-eisu-muhenkan


📝 Commits (1)

  • 4d32e29 Add Eisu_toggle and Muhenkan keys

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 src/lib/barrier/key_types.cpp (+3 -0)
📝 src/lib/barrier/key_types.h (+2 -0)

📄 Description

This request adds key type entries for Eisu_toggle and Muhenkan, which are used in Japanese keyboards for macOS and Windows computers.
It also adds missing entry of kKeyNameMap for kKeyKana.

These keys are important for Japanese input methods that input Japanese characters from alphabets (e.g., "ひらがな" from "hiragana").

  • Henkan and Muhenkan are used to enable and disable input methods, respectively in Windows computers.
    • Henkan is already available in key_types.h and key_types.cpp
  • Kana and Eisu_toggle are used to enable and disable input methods, respectively in macOS computers.
    • Kana is already available in key_types.h but not available in key_types.cpp

This request makes easier for Japanese users to share a keyboard between Windows and macOS computers while keeping the functionality of Japanese input methods.

Note: I searched for keysyms for Eisu_toggle and Muhenkan in the following link: http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/818 **Author:** [@tom-tan](https://github.com/tom-tan) **Created:** 7/27/2020 **Status:** ✅ Merged **Merged:** 8/7/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `add-eisu-muhenkan` --- ### 📝 Commits (1) - [`4d32e29`](https://github.com/debauchee/barrier/commit/4d32e292750333d5f7ddd31bd7368e16dabb1b40) Add Eisu_toggle and Muhenkan keys ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/key_types.cpp` (+3 -0) 📝 `src/lib/barrier/key_types.h` (+2 -0) </details> ### 📄 Description This request adds key type entries for `Eisu_toggle` and `Muhenkan`, which are used in Japanese keyboards for macOS and Windows computers. It also adds missing entry of `kKeyNameMap` for `kKeyKana`. These keys are important for Japanese input methods that input Japanese characters from alphabets (e.g., "ひらがな" from "hiragana"). - `Henkan` and `Muhenkan` are used to enable and disable input methods, respectively in Windows computers. - `Henkan` is already available in `key_types.h` and `key_types.cpp` - `Kana` and `Eisu_toggle` are used to enable and disable input methods, respectively in macOS computers. - `Kana` is already available in `key_types.h` but not available in `key_types.cpp` This request makes easier for Japanese users to share a keyboard between Windows and macOS computers while keeping the functionality of Japanese input methods. Note: I searched for keysyms for `Eisu_toggle` and `Muhenkan` in the following link: http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:59:50 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1702
No description provided.