mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[PR #818] [MERGED] Add key entries for Eisu_toggle and Muhenkan #1702
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#1702
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/debauchee/barrier/pull/818
Author: @tom-tan
Created: 7/27/2020
Status: ✅ Merged
Merged: 8/7/2020
Merged by: @p12tic
Base:
master← Head:add-eisu-muhenkan📝 Commits (1)
4d32e29Add Eisu_toggle and Muhenkan keys📊 Changes
2 files changed (+5 additions, -0 deletions)
View changed files
📝
src/lib/barrier/key_types.cpp(+3 -0)📝
src/lib/barrier/key_types.h(+2 -0)📄 Description
This request adds key type entries for
Eisu_toggleandMuhenkan, which are used in Japanese keyboards for macOS and Windows computers.It also adds missing entry of
kKeyNameMapforkKeyKana.These keys are important for Japanese input methods that input Japanese characters from alphabets (e.g., "ひらがな" from "hiragana").
HenkanandMuhenkanare used to enable and disable input methods, respectively in Windows computers.Henkanis already available inkey_types.handkey_types.cppKanaandEisu_toggleare used to enable and disable input methods, respectively in macOS computers.Kanais already available inkey_types.hbut not available inkey_types.cppThis request makes easier for Japanese users to share a keyboard between Windows and macOS computers while keeping the functionality of Japanese input methods.
Note: I searched for keysyms for
Eisu_toggleandMuhenkanin the following link: http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.