[PR #713] [MERGED] lib/net: Use std::string directly instead of String typedef #1686

New issue

Closed

opened 2026-05-05 07:59:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/713
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: use-std-string-5

📝 Commits (1)

b93bccc lib/net: Use std::string directly instead of String typedef

📊 Changes

8 files changed (+31 additions, -44 deletions)

View changed files

📝 src/lib/net/IDataSocket.h (+1 -2)
📝 src/lib/net/NetworkAddress.cpp (+2 -3)
📝 src/lib/net/NetworkAddress.h (+3 -4)
📝 src/lib/net/SecureListenSocket.cpp (+2 -1)
📝 src/lib/net/SecureSocket.cpp (+9 -11)
📝 src/lib/net/SecureSocket.h (+3 -5)
📝 src/lib/net/XSocket.cpp (+7 -13)
📝 src/lib/net/XSocket.h (+4 -5)

📄 Description

Having a String typedef that points to std::string does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/713 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-std-string-5` --- ### 📝 Commits (1) - [`b93bccc`](https://github.com/debauchee/barrier/commit/b93bcccf57d105052a3b4b0afe9a83d78d297124) lib/net: Use std::string directly instead of String typedef ### 📊 Changes **8 files changed** (+31 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/net/IDataSocket.h` (+1 -2) 📝 `src/lib/net/NetworkAddress.cpp` (+2 -3) 📝 `src/lib/net/NetworkAddress.h` (+3 -4) 📝 `src/lib/net/SecureListenSocket.cpp` (+2 -1) 📝 `src/lib/net/SecureSocket.cpp` (+9 -11) 📝 `src/lib/net/SecureSocket.h` (+3 -5) 📝 `src/lib/net/XSocket.cpp` (+7 -13) 📝 `src/lib/net/XSocket.h` (+4 -5) </details> ### 📄 Description Having a `String` typedef that points to `std::string` does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>