[PR #710] [MERGED] lib/client: Use std::string directly instead of String typedef #1683

New issue

Closed

opened 2026-05-05 07:59:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:59:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/710
Author: @p12tic
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @shymega

Base: master ← Head: use-std-string-2

📝 Commits (1)

a0af288 lib/client: Use std::string directly instead of String typedef

📊 Changes

4 files changed (+23 additions, -26 deletions)

View changed files

📝 src/lib/client/Client.cpp (+8 -10)
📝 src/lib/client/Client.h (+10 -10)
📝 src/lib/client/ServerProxy.cpp (+5 -5)
📝 src/lib/client/ServerProxy.h (+0 -1)

📄 Description

Having a String typedef that points to std::string does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/710 **Author:** [@p12tic](https://github.com/p12tic) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@shymega](https://github.com/shymega) **Base:** `master` ← **Head:** `use-std-string-2` --- ### 📝 Commits (1) - [`a0af288`](https://github.com/debauchee/barrier/commit/a0af288b2b500fae49924c1b27340fa06796b647) lib/client: Use std::string directly instead of String typedef ### 📊 Changes **4 files changed** (+23 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/client/Client.cpp` (+8 -10) 📝 `src/lib/client/Client.h` (+10 -10) 📝 `src/lib/client/ServerProxy.cpp` (+5 -5) 📝 `src/lib/client/ServerProxy.h` (+0 -1) </details> ### 📄 Description Having a `String` typedef that points to `std::string` does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>