[PR #400] Check Inno Setup is installed #1621

New issue

Open

opened 2026-05-05 07:57:53 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:57:53 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/400
Author: @MichaelMcDonnell
Created: 8/17/2019
Status: 🔄 Open

Base: master ← Head: check-for-inno-setup

📝 Commits (1)

b1f4063 Check Inno Setup is installed

📊 Changes

1 file changed (+27 additions, -5 deletions)

View changed files

📝 build_installer.bat (+27 -5)

📄 Description

The build_installer.bat file uses Inno Setup to build the installer. It
does currently not check if Inno Setup is installed, and fails with the
message:
The system cannot find the path specified.
Build failed

That message does not explain how to fix the problem. I have added a
loop to search for Inno Setup 6 and 5. The user installed Inno Setup is
preferred over the system installed version. If Inno Setup cannot be
found then it prints an actionable error message.

I have tested it by:

Not having Inno Setup installed
Running build_installer.bat
Checked that the error message appears.
Installed Inno Setup 6 for my current user
Checked that the error message does not appear.
Checked that the installer package is generated
Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
Verified that Barrier started
Uninstalled Barrier
Uninstalled Inno Setup 6
Installed Inno Setup 6 for all users
Checked that the error message does not appear.
Checked that the installer package is generated
Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
Verified that Barrier started
Uninstalled Barrier
Uninstalled Inno Setup 6
Installed Inno Setup 5
Checked that the error message does not appear.
Checked that the installer package is generated
Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
Verified that Barrier started
Uninstalled Barrier

NOTE: There is an existing issue where you have to manually terminate barrierd.exe after Quitting Barrier. If you do not do that then the uninstaller will not be able to remove everything. It was reproduced with the latest release version (2.3.1).

Fixes #397

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/400 **Author:** [@MichaelMcDonnell](https://github.com/MichaelMcDonnell) **Created:** 8/17/2019 **Status:** 🔄 Open **Base:** `master` ← **Head:** `check-for-inno-setup` --- ### 📝 Commits (1) - [`b1f4063`](https://github.com/debauchee/barrier/commit/b1f40638d1b51aed690e1b1ab06c90de498316fa) Check Inno Setup is installed ### 📊 Changes **1 file changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `build_installer.bat` (+27 -5) </details> ### 📄 Description The build_installer.bat file uses Inno Setup to build the installer. It does currently not check if Inno Setup is installed, and fails with the message: The system cannot find the path specified. Build failed That message does not explain how to fix the problem. I have added a loop to search for Inno Setup 6 and 5. The user installed Inno Setup is preferred over the system installed version. If Inno Setup cannot be found then it prints an actionable error message. I have tested it by: 1. Not having Inno Setup installed 2. Running build_installer.bat 3. Checked that the error message appears. 4. Installed Inno Setup 6 for my current user 5. Checked that the error message does not appear. 6. Checked that the installer package is generated 7. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot 8. Verified that Barrier started 9. Uninstalled Barrier 10. Uninstalled Inno Setup 6 11. Installed Inno Setup 6 for all users 12. Checked that the error message does not appear. 13. Checked that the installer package is generated 14. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot 15. Verified that Barrier started 16. Uninstalled Barrier 17. Uninstalled Inno Setup 6 18. Installed Inno Setup 5 19. Checked that the error message does not appear. 20. Checked that the installer package is generated 21. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot 22. Verified that Barrier started 23. Uninstalled Barrier NOTE: There is an existing issue where you have to manually terminate barrierd.exe after Quitting Barrier. If you do not do that then the uninstaller will not be able to remove everything. It was reproduced with the latest release version (2.3.1). Fixes #397 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>