[PR #216] [CLOSED] reimplement how stdin is read on the cli #1581

New issue

Closed

opened 2026-05-05 07:56:50 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:56:50 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/216
Author: @jwestfall69
Created: 1/1/2019
Status: ❌ Closed

Base: master ← Head: stdin

📝 Commits (3)

b3c5a79 Add StdinListen class and plumbing to use it
c67ad71 Enable new StdinListen and disable old stdin reading code
7c5bfcc Remove old stdin reading code

📊 Changes

8 files changed (+67 additions, -52 deletions)

View changed files

📝 src/lib/barrier/App.cpp (+14 -1)
📝 src/lib/barrier/App.h (+3 -0)
📝 src/lib/barrier/ClientApp.cpp (+5 -0)
📝 src/lib/barrier/ServerApp.cpp (+5 -0)
📝 src/lib/base/EventQueue.cpp (+0 -12)
📝 src/lib/base/EventQueue.h (+0 -3)
📝 src/lib/base/StdinListen.cpp (+24 -21)
📝 src/lib/base/StdinListen.h (+16 -15)

📄 Description

This PR re-implements how stdin reading is done on the cli and has the following fixes over the old

Doesn't trigger an assert() if running a debug build and in daemon mode
Doesn't mess up the terminal if in daemon mode
Doesn't listen for stdin input in daemon mode

Fixes #200

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/216 **Author:** [@jwestfall69](https://github.com/jwestfall69) **Created:** 1/1/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `stdin` --- ### 📝 Commits (3) - [`b3c5a79`](https://github.com/debauchee/barrier/commit/b3c5a79aef7d34df24607e907164b5da13a198e9) Add StdinListen class and plumbing to use it - [`c67ad71`](https://github.com/debauchee/barrier/commit/c67ad71c909f2eb48af28c9c4f3c6bc03e6aff41) Enable new StdinListen and disable old stdin reading code - [`7c5bfcc`](https://github.com/debauchee/barrier/commit/7c5bfcc5ae87c4c984a15261d3ea48b5fe4231b5) Remove old stdin reading code ### 📊 Changes **8 files changed** (+67 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/barrier/App.cpp` (+14 -1) 📝 `src/lib/barrier/App.h` (+3 -0) 📝 `src/lib/barrier/ClientApp.cpp` (+5 -0) 📝 `src/lib/barrier/ServerApp.cpp` (+5 -0) 📝 `src/lib/base/EventQueue.cpp` (+0 -12) 📝 `src/lib/base/EventQueue.h` (+0 -3) 📝 `src/lib/base/StdinListen.cpp` (+24 -21) 📝 `src/lib/base/StdinListen.h` (+16 -15) </details> ### 📄 Description This PR re-implements how stdin reading is done on the cli and has the following fixes over the old 1. Doesn't trigger an assert() if running a debug build and in daemon mode 2. Doesn't mess up the terminal if in daemon mode 3. Doesn't listen for stdin input in daemon mode Fixes #200 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>