[GH-ISSUE #20] overallscale? #13

New issue

Open

opened 2026-05-05 22:01:43 -06:00 by gitea-mirror · 1 comment

gitea-mirror commented

2026-05-05 22:01:43 -06:00

Owner

Originally created by @stoermelder on GitHub (Sep 16, 2020).
Original GitHub issue: https://github.com/airwindows/airwindows/issues/20

Hello Chris, I did a code review recently for the module ports for VCV Rack and noticed different sounding on different samplerates. I know these ports are not done by you, so I did the same test with the VST (for Windows) with the same result.
I'm absolutely no expert in DSP but is it possible that you need the reciprocal value here? I added the line overallscale = 1 / overallscale; and did get a quite consistent sound with various samplerates.
94fd1a76ee/plugins/WinVST/Chorus/ChorusProc.cpp (L19)

Originally created by @stoermelder on GitHub (Sep 16, 2020). Original GitHub issue: https://github.com/airwindows/airwindows/issues/20 Hello Chris, I did a code review recently for the module ports for VCV Rack and noticed different sounding on different samplerates. I know these ports are not done by you, so I did the same test with the VST (for Windows) with the same result. I'm absolutely no expert in DSP but is it possible that you need the reciprocal value here? I added the line `overallscale = 1 / overallscale;` and did get a quite consistent sound with various samplerates. https://github.com/airwindows/airwindows/blob/94fd1a76ee4ffa3ceec3e51e19f678cfba3ab54c/plugins/WinVST/Chorus/ChorusProc.cpp#L19

gitea-mirror commented

2026-05-05 22:01:45 -06:00

Author

Owner

@airwindows commented on GitHub (Sep 17, 2020):

On 9 16, 2020, at 4:49 PM, Ben notifications@github.com wrote:

Hello Chris, I did a code review recently for the module ports for VCV Rack and noticed different sounding on different samplerates. I know these ports are not done by you, so I did the same test with the VST (for Windows) with the same result.
I'm absolutely no expert in DSP but is it possible that you need the reciprocal value here? I added the line overallscale = 1 / overallscale; and did get a quite consistent sound with various samplerates.
94fd1a76ee/plugins/WinVST/Chorus/ChorusProc.cpp (L19)

Very likely so. I’ll have a look and the plugin will be updated if I overlooked this. That would be called a ‘mistake’ :)

Chris

@airwindows commented on GitHub (Sep 17, 2020): > On 9 16, 2020, at 4:49 PM, Ben <notifications@github.com> wrote: > > > Hello Chris, I did a code review recently for the module ports for VCV Rack and noticed different sounding on different samplerates. I know these ports are not done by you, so I did the same test with the VST (for Windows) with the same result. > I'm absolutely no expert in DSP but is it possible that you need the reciprocal value here? I added the line overallscale = 1 / overallscale; and did get a quite consistent sound with various samplerates. > https://github.com/airwindows/airwindows/blob/94fd1a76ee4ffa3ceec3e51e19f678cfba3ab54c/plugins/WinVST/Chorus/ChorusProc.cpp#L19 Very likely so. I’ll have a look and the plugin will be updated if I overlooked this. That would be called a ‘mistake’ :) Chris