[PR #719] [MERGED] Restore software brightness upon startup + some other tweaks. #1191

New issue

Closed

opened 2026-05-05 07:07:14 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:07:14 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/719
Author: @waydabber
Created: 10/17/2021
Status: ✅ Merged
Merged: 10/18/2021
Merged by: @waydabber

Base: master ← Head: experimental

📝 Commits (10+)

218be1e Software brightness changes are reapplied upon startup when 'Apply last saved values to the display' is selected under 'Upon startup or wake' + some other tweaks.
37bc6a3 Fix signing
20ead7c Do not reset software brightness saved preferences on proper app terminate.
8ea9f2e Ops, turn off sw debug flag... :)
361fcfe Fix signing.
e94633e Fix my name in translation files. :)
9c5a3ad Delete docs directory
e102766 Better colorsync restore on display reconfiguration.
fe45f8f Merge remote-tracking branch 'refs/remotes/origin/experimental'
d7646de Update to gamma table reset

📊 Changes

20 files changed (+48 additions, -85 deletions)

View changed files

📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Model/Display.swift (+4 -2)
📝 MonitorControl/Model/OtherDisplay.swift (+2 -2)
📝 MonitorControl/Support/AppDelegate.swift (+9 -12)
📝 MonitorControl/Support/DisplayManager.swift (+9 -7)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+2 -2)
📝 MonitorControl/UI/de.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/en.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/fr.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/hu.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/it.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/ko.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/nl.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/tr.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/zh-Hans.lproj/Main.strings (+2 -2)
📝 MonitorControl/UI/zh-Hant-TW.lproj/Main.strings (+2 -2)
📝 MonitorControlHelper/Info.plist (+1 -1)
➖ docs/CNAME (+0 -1)
➖ docs/appcast.xml (+0 -22)
➖ docs/index.html (+0 -15)

📄 Description

Software brightness changes are reapplied upon startup when 'Apply last saved values to the display' is selected under 'Upon startup or wake'.
On some rare occasions, macOS does not reset gamma tables upon display reconfiguration which caused an erroneus baseline and double dimming in software and combined mode. Now there is a manual reset upon receiving a reconfiguration request as a safety measure to avoid this.
Some minor tweaks regarding how software dimming and gamma table manipulation behaves.
(also I fixed my name in About.)

No need to update translations.

Closes #718

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/719 **Author:** [@waydabber](https://github.com/waydabber) **Created:** 10/17/2021 **Status:** ✅ Merged **Merged:** 10/18/2021 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `master` ← **Head:** `experimental` --- ### 📝 Commits (10+) - [`218be1e`](https://github.com/MonitorControl/MonitorControl/commit/218be1e54cb36eb40ab20ddd7b5839a8280e2491) Software brightness changes are reapplied upon startup when 'Apply last saved values to the display' is selected under 'Upon startup or wake' + some other tweaks. - [`37bc6a3`](https://github.com/MonitorControl/MonitorControl/commit/37bc6a33fb1b8559d0e89a1e23f1d30f5740dd5b) Fix signing - [`20ead7c`](https://github.com/MonitorControl/MonitorControl/commit/20ead7c487590d1fa8d1ac9657b86b01db0addbb) Do not reset software brightness saved preferences on proper app terminate. - [`8ea9f2e`](https://github.com/MonitorControl/MonitorControl/commit/8ea9f2e1947c2a28a15a634d1a11407b7c045d13) Ops, turn off sw debug flag... :) - [`361fcfe`](https://github.com/MonitorControl/MonitorControl/commit/361fcfe11695bc65c1f2ec6a606063802e2a6948) Fix signing. - [`e94633e`](https://github.com/MonitorControl/MonitorControl/commit/e94633e26e4921024529720e841f3a9c714a0bbc) Fix my name in translation files. :) - [`9c5a3ad`](https://github.com/MonitorControl/MonitorControl/commit/9c5a3ad6da3d2e643f505a574dbd3ff38ee3a3a1) Delete docs directory - [`e102766`](https://github.com/MonitorControl/MonitorControl/commit/e102766eed5467f419169cf7ea1adb46ccf59428) Better colorsync restore on display reconfiguration. - [`fe45f8f`](https://github.com/MonitorControl/MonitorControl/commit/fe45f8f6acd6f83e653d4efe3f6d52334b22039f) Merge remote-tracking branch 'refs/remotes/origin/experimental' - [`d7646de`](https://github.com/MonitorControl/MonitorControl/commit/d7646defd60d1c1eaffb50be309dd87c4915e765) Update to gamma table reset ### 📊 Changes **20 files changed** (+48 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Model/Display.swift` (+4 -2) 📝 `MonitorControl/Model/OtherDisplay.swift` (+2 -2) 📝 `MonitorControl/Support/AppDelegate.swift` (+9 -12) 📝 `MonitorControl/Support/DisplayManager.swift` (+9 -7) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+2 -2) 📝 `MonitorControl/UI/de.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/fr.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/hu.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/it.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/ko.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/nl.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/tr.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/zh-Hans.lproj/Main.strings` (+2 -2) 📝 `MonitorControl/UI/zh-Hant-TW.lproj/Main.strings` (+2 -2) 📝 `MonitorControlHelper/Info.plist` (+1 -1) ➖ `docs/CNAME` (+0 -1) ➖ `docs/appcast.xml` (+0 -22) ➖ `docs/index.html` (+0 -15) </details> ### 📄 Description - Software brightness changes are reapplied upon startup when 'Apply last saved values to the display' is selected under 'Upon startup or wake'. - On some rare occasions, macOS does not reset gamma tables upon display reconfiguration which caused an erroneus baseline and double dimming in software and combined mode. Now there is a manual reset upon receiving a reconfiguration request as a safety measure to avoid this. - Some minor tweaks regarding how software dimming and gamma table manipulation behaves. - (also I fixed my name in About.) No need to update translations. Closes #718 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>