github/plivo-node
2
0
Fork 0
mirror of https://github.com/donl/plivo-node.git synced 2026-06-30 06:12:08 -06:00
Code Issues Projects Packages Wiki Activity Actions

Removed range validation for ringtimeout and delaydial

Browse source
This commit is contained in:
LSAITHARUN 2021-07-12 23:50:23 +05:30
parent 4c443abb43
commit f27cfc0be1
2 changed files with 9 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/resources/multiPartyCall.js
View file

@ -106,24 +106,24 @@ export class MultiPartyCall extends PlivoResource{
if(params.ringTimeout || params.ringTimeout === 0){
validParam('ringTimeout', params.ringTimeout, [String, Number], false)
if(Number.isInteger(params.ringTimeout)){
validRange('RingTimeout', params.ringTimeout, false, 15, 120)
}
else{
if(typeof(params.ringTimeout) === 'string'){
validMultipleDestinationIntegers('ringTimeout', params.ringTimeout)
}
else if (!Number.isInteger(params.ringTimeout) && typeof(params.ringTimeout) !== 'string'){
throw new InvalidRequestError("RingTimeout must be of type int or string")
}
}
else {
params.ringTimeout = 45
}
if(params.delayDial){
validParam('delayDial', params.delayDial, [String, Number], false)
if(Number.isInteger(params.delayDial)){
validRange('DelayDial', params.delayDial, false, 1, 120)
}
else{
if(typeof(params.delayDial) === 'string'){
validMultipleDestinationIntegers('delayDial', params.delayDial)
}
else if(!Number.isInteger(params.delayDial) && typeof(params.delayDial) !== 'string'){
throw new InvalidRequestError("Dealydial must be of type int or string")
}
}
else {
params.delayDial = 0

12
lib/rest/utils.js
View file

@ -115,17 +115,7 @@ export function validMultipleDestinationNos(paramName, paramValue, options = {})
export function validMultipleDestinationIntegers(paramName, paramValue){
let val = paramValue.split("<");
for (let i=0; i<val.length; i++){
if (!isNaN(val[i]) && Number.isInteger(parseFloat(val[i]))){
if(paramName=="delayDial"){
if(val[i]!='0'){
validRange('DelayDial Destination Value', parseInt(val[i]), false, 1, 120);
}
}
else if (paramName=="ringTimeout"){
validRange('RingTimeout Destination Value', parseInt(val[i]), false, 15, 120);
}
}
else{
if (!(/^-?\d+$/.test(val[i]))){
throw new InvalidRequestError( paramName + " Destination value must be integer");
}
}