From 9bdc601c1f3b5737d6f81f406af8b617b618f81d Mon Sep 17 00:00:00 2001 From: qyunal Date: Fri, 17 Jan 2020 02:17:13 +0530 Subject: [PATCH 1/4] adds cascade option for delete app API --- lib/resources/applications.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/resources/applications.js b/lib/resources/applications.js index 59af9bb..ff5bf23 100644 --- a/lib/resources/applications.js +++ b/lib/resources/applications.js @@ -49,10 +49,16 @@ export class Application extends PlivoResource { /** * delete application * @method + * @param {boolean} cascade - delete associated endpoints * @promise {object} return true on success * @fail {Error} return Error */ - delete() { + delete(cascade) { + let params = {}; + + if (typeof cascade === 'boolean') { + params.cascade = cascade.toString(); + } return super.delete(); } @@ -157,12 +163,13 @@ export class ApplicationInterface extends PlivoResourceInterface { * delete Application * @method * @param {string} id - id of application + * @param {boolean} cascade - delete associated endpoints * @promise {object} return true on success * @fail {Error} return Error */ - delete(id) { + delete(id, cascade) { return new Application(this[clientKey], { id: id - }).delete(); + }).delete(cascade); } } From 0f5a9742d8101e875ece00d458511812f1e64f58 Mon Sep 17 00:00:00 2001 From: qyunal Date: Tue, 21 Jan 2020 00:07:45 +0530 Subject: [PATCH 2/4] adds appID param adds appID param --- lib/resources/applications.js | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/resources/applications.js b/lib/resources/applications.js index ff5bf23..d0ccb22 100644 --- a/lib/resources/applications.js +++ b/lib/resources/applications.js @@ -49,17 +49,14 @@ export class Application extends PlivoResource { /** * delete application * @method - * @param {boolean} cascade - delete associated endpoints + * @param {object} params - params to delete application + * @param {boolean} [params.cascade] - delete associated endpoints + * @param {string} [params.newEndpointApplication] - link associated endpoints with app * @promise {object} return true on success * @fail {Error} return Error */ - delete(cascade) { - let params = {}; - - if (typeof cascade === 'boolean') { - params.cascade = cascade.toString(); - } - return super.delete(); + delete(params) { + return super.delete(params); } } @@ -163,13 +160,15 @@ export class ApplicationInterface extends PlivoResourceInterface { * delete Application * @method * @param {string} id - id of application - * @param {boolean} cascade - delete associated endpoints + * @param {object} params - params to delete application + * @param {boolean} [params.cascade] - delete associated endpoints + * @param {string} [params.newEndpointApplication] - link associated endpoints with app * @promise {object} return true on success * @fail {Error} return Error */ - delete(id, cascade) { + delete(id, params = {}) { return new Application(this[clientKey], { id: id - }).delete(cascade); + }).delete(params); } } From 4b619aa90f3232f809054cd430e5878afcb81406 Mon Sep 17 00:00:00 2001 From: qyunal Date: Mon, 23 Mar 2020 15:09:56 +0530 Subject: [PATCH 3/4] convert cascade param to string --- lib/resources/applications.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/resources/applications.js b/lib/resources/applications.js index d0ccb22..e340aee 100644 --- a/lib/resources/applications.js +++ b/lib/resources/applications.js @@ -56,6 +56,9 @@ export class Application extends PlivoResource { * @fail {Error} return Error */ delete(params) { + if (typeof params.cascade === 'boolean') { + params.cascade = params.cascade.toString(); + } return super.delete(params); } @@ -167,6 +170,10 @@ export class ApplicationInterface extends PlivoResourceInterface { * @fail {Error} return Error */ delete(id, params = {}) { + if (typeof params.cascade === 'boolean') { + params.cascade = params.cascade.toString(); + } + return new Application(this[clientKey], { id: id }).delete(params); From b792e5db38c3a355b6119da60dc1750a6067d73e Mon Sep 17 00:00:00 2001 From: nixonsamuel Date: Tue, 31 Mar 2020 12:42:13 +0530 Subject: [PATCH 4/4] bump version to 4.5.0 --- CHANGELOG.md | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96dcb77..9a30bb2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Change Log +## [4.5.0](https://github.com/plivo/plivo-node/releases/tag/v4.5.0)(2020-03-31) +- Add application cascade delete support. + ## [4.4.0](https://github.com/plivo/plivo-node/releases/tag/v4.4.0)(2020-03-30) - Add Tollfree support for Powerpack diff --git a/package.json b/package.json index 6215283..e076189 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.4.0", + "version": "4.5.0", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [