Roland Walker
3a48343a03
Merge pull request #4719 from rolandwalker/doctor_refactor
...
refactor `brew cask doctor`
2014-06-06 20:42:45 -04:00
Roland Walker
324d79f0bb
Merge pull request #4673 from rolandwalker/cask_load_exceptions
...
Improve error checking and messages on Cask load
2014-06-06 20:42:35 -04:00
Roland Walker
13f8a4d282
remove issues_url and nullcommand from help output
...
necessitated by Homebrew's switch to Ruby 2.x
Fixes #4728
Fixes #4726
2014-06-06 17:10:28 -04:00
Roland Walker
abe4428cb6
add $SHELL to doctor
2014-06-06 14:15:48 -04:00
Roland Walker
40215968ef
add $CHRUBY_VERSION to doctor
2014-06-06 14:15:34 -04:00
Fernando Paredes
b767f9f1e6
Add OS X 10.10 as a known OS version
...
* In Yosemite the tests failed for being unknown
2014-06-06 10:56:41 -07:00
Roland Walker
50841d3f86
whitespace
2014-06-06 11:34:45 -04:00
Roland Walker
c857f11965
add PATH to doctor
2014-06-06 11:33:15 -04:00
Roland Walker
a9121320f8
add render_env_var in doctor
...
add quoting
2014-06-06 11:32:15 -04:00
Roland Walker
e6e5626bbc
warning on old-style tap paths in doctor
2014-06-06 11:25:35 -04:00
Roland Walker
796104b786
move homebrew_origin to method in doctor
2014-06-06 11:08:19 -04:00
Roland Walker
6a7cda5c24
move default_cask_count to method in doctor
2014-06-06 11:08:19 -04:00
Roland Walker
8388d1c3ac
move alt_taps to method in doctor
2014-06-06 11:08:18 -04:00
Roland Walker
c354e53cc3
move fq_default_tap to method in doctor
2014-06-06 11:08:18 -04:00
Roland Walker
8a5ad08dc8
move privledged_uid to method in doctor
2014-06-06 11:08:18 -04:00
Roland Walker
9f2c773ed6
move notfound_string to method
2014-06-06 11:00:32 -04:00
Roland Walker
fc9e7299ed
add locale variables to doctor
...
references: #4677
2014-06-06 11:00:32 -04:00
Roland Walker
f6011c85c9
render empty doctor values with <NONE>
2014-06-06 10:37:01 -04:00
Roland Walker
1400b61acf
abstract error_string in doctor
2014-06-06 10:36:56 -04:00
Roland Walker
a517e25acd
abstract none_string in doctor
2014-06-06 10:36:46 -04:00
Roland Walker
0ef4606e0c
retire support for no_checksum stanza
2014-06-04 23:26:09 -04:00
Roland Walker
c082b5521a
Improve error checking and messages on Cask load
...
Other Cask sources ultimately invoke the `load` method in the
abstract class Cask::Source::PathBase, so these changes apply
to all other sources.
2014-06-04 07:34:52 -04:00
Roland Walker
96ebb64320
Merge pull request #4658 from rolandwalker/demote_implicit_path_source
...
Demote implicit Cask path sources (i.e. files in current working directory)
2014-06-03 19:14:52 -04:00
Roland Walker
787b471618
isolate ErrorDuringExecution rescue
...
it only should be rescued for the `curl` invocation
2014-06-03 11:39:58 -04:00
Roland Walker
9797d2770f
doc: improve Cask-source-resolution debug message
2014-06-03 10:39:18 -04:00
Roland Walker
f24b4ba05a
show resolved Cask source file or URI w/ --debug
...
references #4641
2014-06-03 10:38:49 -04:00
Roland Walker
f8c9567a66
Don't prefer Cask files in the cwd
...
Fixes #4641 . Cask files in the cwd are still permitted, but
at the very lowest priority, below Tapped Cask names.
2014-06-03 10:33:19 -04:00
Roland Walker
290d1ccb38
ChecksumMismatchError is ordinary exception
...
not a bug
2014-06-02 23:26:19 -04:00
Roland Walker
1b9df93e20
no need to catch CaskAlreadyInstalledError
...
separately; it is already descended from CaskError
2014-06-02 23:24:59 -04:00
Roland Walker
d4fb446830
Merge pull request #4603 from rolandwalker/doctor_homebrew_origin
...
show Homebrew repo & origin in doctor
2014-05-31 15:19:37 -04:00
Roland Walker
9fdc5b3fd9
show Homebrew repo & origin in doctor
...
references: #4581 , #4571
2014-05-31 07:58:22 -04:00
Roland Walker
f71ed25ee0
rescue download failure; don't show traceback
...
instead, give a more specific error message. Closes #4556 .
2014-05-26 15:56:35 -04:00
Roland Walker
5b2e9d1466
doc/comment: known performance issues
2014-05-15 16:52:41 -04:00
Roland Walker
3c40e82c18
generate installed list only once during list cmd
2014-05-15 16:52:17 -04:00
Roland Walker
c3e514defe
optimize Cask.installed by guessing full paths
2014-05-15 16:50:42 -04:00
Roland Walker
598f53ba48
memoize all_tapped_cask_dirs
2014-05-15 16:49:43 -04:00
Roland Walker
03af4f45a1
make cask_titles hold Pathnames, not strings
2014-05-15 16:38:35 -04:00
Roland Walker
d0db956d69
refactor brew cask doctor
...
Output remains the same (except in the case of error).
Wrap all calculations in begin blocks for safety, provide fallback
values for all variables, don't use ohai+puts when ohai is
sufficient
2014-05-15 12:55:23 -04:00
Roland Walker
abd66acba1
Merge pull request #4370 from rolandwalker/uninstall_signal
...
add `:signal` directive for `uninstall`
2014-05-14 06:26:49 -04:00
Roland Walker
d4c89509c2
Merge pull request #4382 from rolandwalker/no_doubledash_launchctl_remove
...
don't use doubledash on launchctl remove
2014-05-14 06:26:27 -04:00
Roland Walker
6815ef272e
don't use doubledash on launchctl remove
...
it appears to be incorrect here: removal of jobs is hindered
2014-05-13 18:52:35 -04:00
Roland Walker
b38d6a6977
add :signal directive for uninstall
...
to send arbitrary Unix signals. Per discussion in #4328 , some
processes are resistant to the `:quit` directive, and can be
made to shut down via a signal.
2014-05-13 13:04:10 -04:00
Roland Walker
5101d363ab
append the .rb extension on Cask::Source::Path
...
Unless `.rb` is already present on the query string. Failure
to append the extension caused confusing effects, including
selective failure of "brew cask list" when invoked from
`/usr/local/bin` working directory. Fixes #4077 .
Credit to @mroth on the detective work.
2014-05-13 09:04:14 -04:00
Roland Walker
cfc6ae7a13
Merge pull request #4264 from rolandwalker/retire_sha1
...
Retire support for `sha1` stanza.
2014-05-08 18:37:00 -04:00
Roland Walker
0808c0f3f9
handle Tap read error in brew cask doctor
2014-05-08 14:53:30 -04:00
Roland Walker
34df5309d4
Retire support for sha1 stanza.
...
We haven't received new submissions using `sha1` for quite
some time.
2014-05-08 12:01:32 -04:00
Roland Walker
c436ddc5fd
transition docs/tests/messages to sha256 :no_check
...
`sha256 :no_check` has been supported syntax for a couple of months,
and now is being transitioned to the preferred syntax, replacing
the `no_checksum` stanza (which will still be supported, but
deprecated)
2014-05-08 08:42:44 -04:00
Roland Walker
89082904c4
cut v0.35.0
2014-05-08 07:48:34 -04:00
Roland Walker
dd5d767b18
Merge pull request #4244 from rolandwalker/toplevel_dir_permissions
...
special case permissions when creating `/opt`
2014-05-07 22:36:42 -04:00
Roland Walker
4f82dda065
Merge pull request #4242 from rolandwalker/cat_documentation
...
update docs and messages for `brew cask cat`
2014-05-07 22:34:07 -04:00
