Commit graph

13 commits

Author SHA1 Message Date
Roland Walker
add0279512 Merge pull request #9478 from caskroom/rename-cleanup-cli-option
cli: [refactor] rename outdated option internally
2015-02-07 19:12:13 -05:00
Paul Hinze
5bbba24bf9 cli: [refactor] rename outdated option internally
The `Hbc.outdated` boolean was in the way of my implementation of an
`outdated` scope for `brew cask outdated`, so I took the opportunity to:

 * rename the flag internally to `cleanup_outdated`
 * move the cleanup tests over to rspec and rework them to test in a
   stubbed cleanroom environment
 * refactor the implementation of cleanup to make it a bit more
   testable - most importantly: inject the cache location and outdated
   config dependencies instead of looking them up from constants

Note that there's no change to the user-facing interface, it's still

```
brew cask cleanup --outdated
```
2015-02-07 18:06:51 -06:00
Paul Hinze
63d748e14c core: [refactor] separate Hbc::Cask from Hbc
Hbc is the namespace, Hbc::Cask is the object representing a Cask

One step on the path to reducing the surface area of the God-object
we've grown over the years. :)
2015-02-07 16:37:32 -06:00
Roland Walker
8a81cb54a1 Use bold terminal escapes instead of white
Let the terminal decide how to display bold.  Fixes #9349.
The issue arose when integrating Homebrew's `Tty` class.
Homebrew's `Tty.white` actually emits escapes for bold.

Fixing `Tty.white` to do what the method name says caused
loss of visibility on light backgrounds.
2015-02-07 12:16:45 -05:00
Paul Hinze
d8942b7210 alfred: bring back cli command as stub
Make `brew cask alfred` inform the user about the new Alfred support for
Casks. Should help with the transition.

refs #9405
2015-02-06 09:52:06 -06:00
Vítor Galvão
0ae2edd707 Merge pull request #8840 from vitorgalvao/remove-alfred
Removed alfred command support
2015-01-13 21:27:17 +00:00
Vítor Galvão
078f0b0300 removed alfred support 2015-01-13 17:49:32 +00:00
Roland Walker
a401047164 remove homebrew-fork MACOS_RELEASE constants
* contain logic within module Hbc::MacOS
* add release_with_patchlevel method
* allow MACOS_RELEASE and MACOS_RELEASE_WITH_PATCHLEVEL
  environment variables to override the determined release
  values regardless of whether under the test harness
2015-01-13 07:35:27 -05:00
ndr
d5722ee079 Merge pull request #8751 from vitorgalvao/remove-widget-support
Remove support for widgets
2015-01-11 12:29:00 +00:00
Vítor Galvão
529bd801e4 Removed support for widgets
Closes #2206.
2015-01-08 19:51:15 +00:00
Roland Walker
b40b0c99e1 strip constants from homebrew-fork global.rb
and corresponding testing_env.rb.
* recast HOMEBREW_BREW_FILE as Hbc.homebrew_executable,
  defined in Hbc::Locations
* recast HOMEBREW_REPOSITORY as Hbc.homebrew_repository
* recast HOMEBREW_PREFIX as Hbc.homebrew_prefix
* remove HOMEBREW_LIBRARY
* recast existing Hbc.tapspath as Hbc.homebrew_tapspath
  to match new methods

fixes #8705
2015-01-07 09:09:53 -05:00
Roland Walker
774eae75a8 replace homebrew-fork method exec_editor
remove which_editor
remove safe_exec
2015-01-03 07:59:51 -05:00
Roland Walker
202d6019f8 Move all code under an Hbc:: namespace
* convert existing Cask:: namespace to Hbc::
* move Homebrew-fork code under Hbc::
* move freestanding classes such as Tty and TopologicalHash under Hbc::
* recast HOMEBREW_CASK_ constants as HBC_
* modify our Homebrew Formula for backward compatibility
* devscripts and dev docs
2015-01-02 07:27:03 -05:00