Commit graph

841 commits

Author SHA1 Message Date
Roland Walker
e5d4765135 Merge pull request #7933 from rolandwalker/comment_unknown_license
mark `license :unknown` with explicit todo comment
2014-12-10 08:42:18 -05:00
Roland Walker
2c3119da03 cut v0.50.0 2014-12-09 19:56:19 -05:00
Roland Walker
542fd838e6 Merge pull request #7958 from rolandwalker/return_path_from_fetch
return tarball_path from fetch method
2014-12-09 19:15:04 -05:00
Roland Walker
93b348b480 Merge pull request #7936 from rolandwalker/macos_release_alias
add `MacOS.release` alias for `MacOS.version`
2014-12-09 18:49:59 -05:00
Roland Walker
dc30c6fb90 Merge pull request #7940 from rolandwalker/postflight_user_errors
sanity checks and error handling in postflight mini-DSL
2014-12-09 18:49:38 -05:00
Roland Walker
6ef309aff0 return tarball_path from fetch method
fixes #7946
2014-12-09 18:43:24 -05:00
Roland Walker
2e2023b88b Be more consistent/liberal about stanza accessors.
Return the current value whenever the stanza method is called
without arguments, including when the stanza has no value.  Do
not attempt to construct an instance with no arguments (which
typically throws an exception).

Incidental comment re: depends_on

Refs #7880
2014-12-09 11:16:48 -05:00
Roland Walker
a808befdd6 sanity checks/error handling, postflight miniDSL
report errors in all user-facing methods
2014-12-09 10:49:03 -05:00
Roland Walker
b3836f581d recast info_plist as info_plist_file 2014-12-09 10:47:23 -05:00
Roland Walker
6da48b07a3 add MacOS.release alias for MacOS.version
* to match phrasing in our documentation
* to distinguish against the Cask `version` (of which there may
  be more than one in the future)
* better fit with symbolic release names eg `:yosemite`
* `MacOS.release` itself is intentionally undocumented pending
  the next code release
2014-12-09 08:45:37 -05:00
Roland Walker
568a8229c3 mark license :unknown with explicit todo comment 2014-12-09 07:48:45 -05:00
Roland Walker
65a71e75eb remove assistive_devices caveats method
backward-compat, replaced by toplevel `accessibility_access`
2014-12-08 19:26:13 -05:00
Roland Walker
972883e6c2 Merge pull request #7898 from rolandwalker/internal_stanza_installer
enable `installer` artifact in `_stanza` verb
2014-12-08 19:24:47 -05:00
Roland Walker
82826b2687 DSL: add accessibility_access stanza
* accepts a Boolean value
* replaces the never-documented `postflight` methods `enable_accessibility_access` /
 `disable_accessibility_access` (`remove_accessibility_access`)
* declarative: unlike the `postflight` approach, does not have to be
  invoked in two places
* de-document obsolete form `caveats` / `assistive_devices`
* bump Travis seed to avoid false test failures
2014-12-08 19:17:19 -05:00
Roland Walker
00217148ef enable installer artifact in _stanza verb
Since `installer` is a type of artifact, it must be listed
explicitly, though this repetition indicates poor design.
2014-12-08 10:39:15 -05:00
Roland Walker
2e71e5110d remove newlines from runtime bundle IDs
* create `staged_test.rb` for testing staged Casks
* test an actual staged Cask rather than mocking
2014-12-08 10:32:18 -05:00
Roland Walker
98fa063277 Merge pull request #7895 from claui/fix-system-command-exit-status
In `SystemCommand`, fix `success?` and `exit_status`
2014-12-08 10:31:06 -05:00
Claudia
7f5dc211ba In SystemCommand, fix success? and exit_status
When invoking a `SystemCommand` with `:must_succeed => false`, the `SystemCommand::Result` class would mistake a `Process.Status` object for a `Fixnum`.

This commit fixes this by instantiating `Result` with the actual status code as a number.
2014-12-08 15:53:35 +01:00
Roland Walker
25ff85451d Merge pull request #7893 from claui/fix-brew-cask-dump-ruby18
Fix an issue with `--debug` and `_dump` on Ruby 1.8.7
2014-12-08 07:50:46 -05:00
Roland Walker
1ddbf0e72e Merge pull request #7848 from rolandwalker/remove_x11_required
remove `caveats` / `x11_required`
2014-12-08 05:41:00 -05:00
Roland Walker
09bed7a53b Merge pull request #7845 from rolandwalker/depends_on_x11
DSL: add `depends_on :x11`, permit multiple `depends_on` stanzas
2014-12-08 05:40:45 -05:00
Claudia
5eb24daada Fix an issue with --debug and _dump on Ruby 1.8.7
This fixes an issue where both the `--debug` option and the `brew cask _dump` command would fail on Ruby 1.8.7 when the Cask has an `installer` stanza, e. g. `adobe-air`.
2014-12-08 11:20:41 +01:00
Roland Walker
69d0f98042 remove caveats / x11_required 2014-12-06 11:46:00 -05:00
Roland Walker
5348260520 DSL: add depends_on :x11 2014-12-06 11:20:15 -05:00
Roland Walker
e581347939 allow multiple depends_on stanzas + refactor
also:
* disallow combining depends_on :macos comparison expressions
* ohai message when depends_on is present
* explicit accessors for :cask and :formula
* simplify some logic and flatten nested conditionals
* reflow incidental doc
2014-12-06 11:06:30 -05:00
Roland Walker
a870869f9a Merge pull request #7822 from rolandwalker/allow_leading_numbers
Remove constraint that Cask tokens cannot start with digits
2014-12-06 09:00:04 -05:00
Roland Walker
d7956e597d DSL: remove support for tags :name 2014-12-06 08:03:03 -05:00
Roland Walker
27c49e31a5 Merge pull request #7825 from rolandwalker/remove_title_support
remove support for `title` method in Casks
2014-12-06 07:56:09 -05:00
Roland Walker
2a09a970cd Merge pull request #7819 from rolandwalker/depends_on_followup
followups on `depends_on` `:macos`/`:arch`
2014-12-06 07:55:13 -05:00
Roland Walker
f5bcbd00a5 Merge pull request #7805 from rolandwalker/add_name_stanza
Add `name` stanza for proper name
2014-12-06 05:28:30 -05:00
Roland Walker
8170c34785 DSL: remove arch_only caveats support 2014-12-05 18:46:51 -05:00
Roland Walker
a6bc35cfa8 remove support for title method in Casks
obsoleted by `token`
2014-12-05 18:41:24 -05:00
Roland Walker
b7eb666557 Merge pull request #7794 from rolandwalker/remove_os_version_only_caveat
remove `os_version_only` support from `caveats`
2014-12-05 18:34:44 -05:00
Roland Walker
cb5a40f787 remove constraint that tokens can't start w/ digit
Class names are now completely hidden from the user.  This
commit works by adding a prefix to all Cask class names, which
is considered to be an ugly transitional hack on the way to
representing individual Casks as instances.
2014-12-05 11:54:56 -05:00
Roland Walker
037ece852b followups on depends_on :macos/:arch
* always coerce `:macos` value to array; simplify code
 * remove warning comments about unset values
 * doc explicitly that requirements are covered as well as dependencies
 * doc that `depends_on` is not consulted until `install` time
 * in docs and code, say "release" instead of "version" for the :macos release
   * todo: provide our own variable styled "release" to use in Casks, instead of Homebrew's `MacOS.Version`
 * doc that symbols are preferred for `:macos` over strings in Casks (interally, all are converted to idential `Gem::Version` objects)
 * doc: remove `os_version_only` from `cask_language_deltas.md`
 * doc: improve internal links
 * doc: recast OS X release symbol list as table
 * doc: (incidental) regularize orthography of Formula and Cask
2014-12-05 09:55:47 -05:00
Roland Walker
89ec82d9f8 Merge pull request #7793 from rolandwalker/depends_on_arch
DSL: `depends_on :arch` functionality/tests/doc
2014-12-05 09:40:36 -05:00
Roland Walker
f800db0383 Add name stanza for proper name
Documentation is in a separate PR so that authors don't start
using this feature before release.
2014-12-04 20:08:55 -05:00
Roland Walker
bf96caa2b3 convert more backend code from cask_name to token
missed in #7673
2014-12-04 18:48:33 -05:00
Roland Walker
dc93af470d remove os_version_only from caveats
obsoleted by `depends_on :macos`
2014-12-04 14:54:05 -05:00
Roland Walker
7f5e5124f6 DSL: depends_on :arch functionality/tests/doc
* fill in functionality for the `depends_on :arch` stub
* de-document `caveats` method `arch_only`
2014-12-04 14:29:27 -05:00
Roland Walker
52fdbcd671 cut v0.49.0 2014-12-02 13:04:59 -05:00
Roland Walker
1c5c6ae774 Merge pull request #7738 from claui/fix-brew-cask-list-ruby18
Fix regression where some CLI commands break on Ruby 1.8
2014-12-02 12:50:59 -05:00
Roland Walker
f7fb88065e Merge pull request #7740 from rolandwalker/relax_sourceforge_jp
relax sourceforge.jp URL pattern
2014-12-02 12:50:12 -05:00
Roland Walker
ddc865311f missing "require 'rubygems'"
for depends_on :macos
2014-12-02 12:49:51 -05:00
Roland Walker
2614a447a2 relax sourceforge.jp URL pattern 2014-12-02 12:24:36 -05:00
Roland Walker
c59a5fcb80 DSL: depends_on :macos functionality/tests/doc
* Fill in the functionality for the `depends_on :macos` stub
* de-document `caveats` method `os_version_only`
* clean up some related docs re: version strings
* add `depends_on_test.rb`
* clarify some related `depends_on :formula` doc, tests, and code
* formatting in test Casks
2014-12-02 12:04:27 -05:00
Claudia
03a8efe128 Make CLI::Alfred and Source::PathBase work with Ruby 1.8 2014-12-02 17:01:01 +01:00
Roland Walker
9050f4d301 Merge pull request #7684 from rolandwalker/accessibility_review
Review and revise accessibility methods in postflight mini-DSL
2014-12-02 05:19:39 -05:00
Roland Walker
bff136da57 Merge pull request #7685 from rolandwalker/plist_postflight_review
review/revise plist methods in postflight mini-DSL
2014-12-02 05:19:12 -05:00
Roland Walker
d0d50fd935 Merge pull request #7686 from rolandwalker/move_to_app_postflight_review
review/revise `suppress_move_to_applications` method in postflight mini-DSL
2014-12-02 05:19:00 -05:00