From a12698efa2902b2cf088df4e75973cb6383320fc Mon Sep 17 00:00:00 2001 From: Roland Walker Date: Fri, 3 Oct 2014 10:13:31 -0400 Subject: [PATCH] comments in download_strategy.rb --- lib/cask/download_strategy.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/cask/download_strategy.rb b/lib/cask/download_strategy.rb index 284af080d..529847ca2 100644 --- a/lib/cask/download_strategy.rb +++ b/lib/cask/download_strategy.rb @@ -1,8 +1,8 @@ require 'cgi' # We abuse Homebrew's download strategies considerably here. -# * Our downloader instances only invoke the fetch method, -# ignoring stage and clear_cache. +# * Our downloader instances only invoke the fetch and +# clear_cache methods, ignoring stage # * Our overridden fetch methods are expected to return # a value: the successfully downloaded file. @@ -147,6 +147,10 @@ class Cask::SubversionDownloadStrategy < SubversionDownloadStrategy private + # TODO/UPDATE: the tar approach explained below is fragile + # against challenges such as case-sensitive filesystems, + # and must be re-implemented. + # # Seems nutty: we "download" the contents into a tape archive. # Why? # * A single file is tractable to the rest of the Cask toolchain,