[GH-ISSUE #224] More colors? #83

Closed
opened 2026-05-05 03:38:39 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @XKFS on GitHub (Jan 4, 2025).
Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/224

I was using colors for my notepad fonts. It has necessary color variant but I think adding some additional colors can be helpful. There are 3 primary colors and 3 opposite colors. All 6 of them have Light variant. There is also brown which doesn't have shade shift so light variant will not work. So I think it feels appropriate to add additional 2 colors with brown so that is matches 3 total that have almost no pure light variant. For example, Orange. Pink seems to also match that as pink itself looks similar to light magenta while being a basic color. Dark variant colors would look cool also. For example, DkRed would have the color value of (64 or 128, 0, 0). I can do a pull request in color.h and add it to the documentation also.

What you guys think about it?

Originally created by @XKFS on GitHub (Jan 4, 2025). Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/224 I was using colors for my notepad fonts. It has necessary color variant but I think adding some additional colors can be helpful. There are 3 primary colors and 3 opposite colors. All 6 of them have Light variant. There is also brown which doesn't have shade shift so light variant will not work. So I think it feels appropriate to add additional 2 colors with brown so that is matches 3 total that have almost no pure light variant. For example, Orange. Pink seems to also match that as pink itself looks similar to light magenta while being a basic color. Dark variant colors would look cool also. For example, DkRed would have the color value of (64 or 128, 0, 0). I can do a pull request in color.h and add it to the documentation also. What you guys think about it?
Author
Owner

@klugier commented on GitHub (Mar 22, 2025):

Please create PR. We will take a look... In the worst case, we will reject it :)

<!-- gh-comment-id:2745307255 --> @klugier commented on GitHub (Mar 22, 2025): Please create PR. We will take a look... In the worst case, we will reject it :)
Author
Owner

@XKFS commented on GitHub (Apr 5, 2025):

Oh wow. Thanks, I will create it, it is a simple idea that isn't really that beneficial so you can reject it if it does not help that much

<!-- gh-comment-id:2780216925 --> @XKFS commented on GitHub (Apr 5, 2025): Oh wow. Thanks, I will create it, it is a simple idea that isn't really that beneficial so you can reject it if it does not help that much
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#83
No description provided.