github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #373] [CLOSED] Fix MSVC warnings (Feb2026). #354

New issue
Closed
opened 2026-05-05 03:46:30 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:46:30 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/373
Author: @klugier
Created: 2/22/2026
Status: ❌ Closed

Base: master ← Head: klugier/msvc-warnings

📝 Commits (2)

  • 19123a2 Fix MSVC warnings (Feburary 2026).
  • f703488 ValueCache warnings V2

📊 Changes

5 files changed (+12 additions, -8 deletions)

View changed files

📝 uppsrc/Draw/ImageOp.h (+1 -1)
📝 uppsrc/RichEdit/DiagramIcon.cpp (+2 -2)
📝 uppsrc/RichText/Diagram.cpp (+1 -1)
📝 uppsrc/ide/Log.cpp (+4 -2)
📝 uppsrc/ide/MainConfig.cpp (+4 -2)

📄 Description

It looks like we have bunch of new MSVC compilation warnings. This PR address it. We should make sure our new release will be free from MSVC warnings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/373 **Author:** [@klugier](https://github.com/klugier) **Created:** 2/22/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/msvc-warnings` --- ### 📝 Commits (2) - [`19123a2`](https://github.com/ultimatepp/ultimatepp/commit/19123a28a32a0d6389bd84af2de5d949cdc97f20) Fix MSVC warnings (Feburary 2026). - [`f703488`](https://github.com/ultimatepp/ultimatepp/commit/f703488df417895483a4f7559f65756632e1bf87) ValueCache warnings V2 ### 📊 Changes **5 files changed** (+12 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Draw/ImageOp.h` (+1 -1) 📝 `uppsrc/RichEdit/DiagramIcon.cpp` (+2 -2) 📝 `uppsrc/RichText/Diagram.cpp` (+1 -1) 📝 `uppsrc/ide/Log.cpp` (+4 -2) 📝 `uppsrc/ide/MainConfig.cpp` (+4 -2) </details> ### 📄 Description It looks like we have bunch of new MSVC compilation warnings. This PR address it. We should make sure our new release will be free from MSVC warnings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:46:30 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#354
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?