[PR #372] [CLOSED] Fix issue with erasing UppOut from TheIDE #353

New issue

Closed

opened 2026-05-05 03:46:30 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:46:30 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/372
Author: @klugier
Created: 2/21/2026
Status: ❌ Closed

Base: master ← Head: klugier/fix-clean-uppout

📝 Commits (1)

b9ea857 Fix issue with erasing UppOut from TheIDE

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 uppsrc/ide/Build.cpp (+6 -1)

📄 Description

The current implementation of Ide::CleanUppOut is broken. It removes the application's direct build directory, which requires the target to have been built at least once. Otherwise the clean operation fails. It also doesn’t remove the actual upp.out user data we want to clean (for example, ~/.config/upp.out). So, the current implementation just performs a partial cleaning.

I added an extra check to prevent accidentally passing an empty directory path, which could cause serious harm to the user. Although the new implementation makes that scenario very unlikely since we are not relay on target variable that is set during the build process.

Original issue https://www.ultimatepp.org/forums/index.php?t=msg&goto=61921&#msg_61921

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/372 **Author:** [@klugier](https://github.com/klugier) **Created:** 2/21/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/fix-clean-uppout` --- ### 📝 Commits (1) - [`b9ea857`](https://github.com/ultimatepp/ultimatepp/commit/b9ea857a427df3c59a866a04373f52659ce79127) Fix issue with erasing UppOut from TheIDE ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/ide/Build.cpp` (+6 -1) </details> ### 📄 Description The current implementation of Ide::CleanUppOut is broken. It removes the application's direct build directory, which requires the target to have been built at least once. Otherwise the clean operation fails. It also doesn’t remove the actual upp.out user data we want to clean (for example, ~/.config/upp.out). So, the current implementation just performs a partial cleaning. I added an extra check to prevent accidentally passing an empty directory path, which could cause serious harm to the user. Although the new implementation makes that scenario very unlikely since we are not relay on target variable that is set during the build process. Original issue https://www.ultimatepp.org/forums/index.php?t=msg&goto=61921&#msg_61921 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:46:30 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#353

No description provided.

Rows
Columns