[PR #369] [CLOSED] CtrlCore: Fix GTK file drop to Dolphin and Firefox on Wayland #350

New issue

Closed

opened 2026-05-05 03:46:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:46:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/369
Author: @klugier
Created: 2/9/2026
Status: ❌ Closed

Base: master ← Head: klugier/dnd-dolphin-fix

📝 Commits (4)

3648caa CtrlCore: fix GTK file drop to Dolphin.
44c32f9 .standardisation
14c1d3c .revert changes with carrier return.
f33618a .cosmetics

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlCore/GtkClip.cpp (+3 -1)

📄 Description

It looks like we need to recover slashes after doing UrlEncode. So, instead of having following path:

file://%2Fhome%2Fklugier%2Fupp%2Ffr-fr.udc

It should be

file:///home/klugier/upp/fr-fr.udc

After changing the logic drop to Dolphin and Firefox on Wayland works as expected.

I tested also on pure X11 and it works as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/369 **Author:** [@klugier](https://github.com/klugier) **Created:** 2/9/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/dnd-dolphin-fix` --- ### 📝 Commits (4) - [`3648caa`](https://github.com/ultimatepp/ultimatepp/commit/3648caac47f8c8d877547ff7392b59b9a5ce5012) CtrlCore: fix GTK file drop to Dolphin. - [`44c32f9`](https://github.com/ultimatepp/ultimatepp/commit/44c32f9f8d8b460fd2a3c996b5183df9ebba783f) .standardisation - [`14c1d3c`](https://github.com/ultimatepp/ultimatepp/commit/14c1d3cc070ebde2346bce43b52801a01e15ce0e) .revert changes with carrier return. - [`f33618a`](https://github.com/ultimatepp/ultimatepp/commit/f33618a08e710954377fdac99613fb75aacf961e) .cosmetics ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/GtkClip.cpp` (+3 -1) </details> ### 📄 Description It looks like we need to recover slashes after doing UrlEncode. So, instead of having following path: ``` file://%2Fhome%2Fklugier%2Fupp%2Ffr-fr.udc ``` It should be ``` file:///home/klugier/upp/fr-fr.udc ``` After changing the logic drop to Dolphin and Firefox on Wayland works as expected. I tested also on pure X11 and it works as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:46:28 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#350

No description provided.

Rows
Columns