github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #349] [MERGED] RichEdit: Fix to compile with x86 MSVC compiler. #333

New issue
Closed
opened 2026-05-05 03:46:00 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:46:00 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/349
Author: @klugier
Created: 1/17/2026
Status: ✅ Merged
Merged: 1/18/2026
Merged by: @mirek-fidler

Base: master ← Head: klugier/fix-to-compile-x86

📝 Commits (1)

  • f918211 RichEdit: Fix to compile with x86 MSVC compiler.

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 uppsrc/RichEdit/DiagramBar.cpp (+1 -1)
📝 uppsrc/RichEdit/DiagramIcon.cpp (+1 -1)

📄 Description

It looks like 32 bit version of RichEdit code is no longer compatible with x86 MSVC compiler. This PR address this issue.

The errors are:

C:\Prototable\upp\git\uppsrc\RichEdit\DiagramIcon.cpp (44): error C2666: ,Upp::Point_<double>::operator -": overloaded functions have similar conversions
C:\Prototable\upp\git\uppsrc\RichEdit\DiagramBar.cpp (106): error C2666: ,Upp::Point_<double>::operator -": overloaded functions have similar conversions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/349 **Author:** [@klugier](https://github.com/klugier) **Created:** 1/17/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/fix-to-compile-x86` --- ### 📝 Commits (1) - [`f918211`](https://github.com/ultimatepp/ultimatepp/commit/f918211a2904cd6d0b7689cdecb8af287a86dd20) RichEdit: Fix to compile with x86 MSVC compiler. ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/RichEdit/DiagramBar.cpp` (+1 -1) 📝 `uppsrc/RichEdit/DiagramIcon.cpp` (+1 -1) </details> ### 📄 Description It looks like 32 bit version of RichEdit code is no longer compatible with x86 MSVC compiler. This PR address this issue. The errors are: ``` C:\Prototable\upp\git\uppsrc\RichEdit\DiagramIcon.cpp (44): error C2666: ,Upp::Point_<double>::operator -": overloaded functions have similar conversions C:\Prototable\upp\git\uppsrc\RichEdit\DiagramBar.cpp (106): error C2666: ,Upp::Point_<double>::operator -": overloaded functions have similar conversions ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:46:00 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#333
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?