github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 06:05:58 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #342] [MERGED] Core: Fix LaunchWebBrowser on macOS to handle addresses with dolar sign. #328

New issue
Closed
opened 2026-05-05 03:45:52 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:45:52 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/342
Author: @klugier
Created: 1/6/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @mirek-fidler

Base: master ← Head: klugier/link-with-dolars-handling-on-macos

📝 Commits (1)

  • 0785dbc Core: Fix LaunchWebBrowser on macOS to handle addresses with dolar sign.

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 uppsrc/Core/App.cpp (+3 -1)

📄 Description

In TheIDE handling for these links doesn't work as expected:

menu.AddMenu("Online documentation..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$documentation$en-us.html"));
menu.AddMenu("Common information..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$community$en-us.html"));

The solution is to escape $ dolar signs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/342 **Author:** [@klugier](https://github.com/klugier) **Created:** 1/6/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/link-with-dolars-handling-on-macos` --- ### 📝 Commits (1) - [`0785dbc`](https://github.com/ultimatepp/ultimatepp/commit/0785dbc56ae459e7c28eb0cf97579fb42b1ef3b3) Core: Fix LaunchWebBrowser on macOS to handle addresses with dolar sign. ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Core/App.cpp` (+3 -1) </details> ### 📄 Description In TheIDE handling for these links doesn't work as expected: ``` menu.AddMenu("Online documentation..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$documentation$en-us.html")); menu.AddMenu("Common information..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$community$en-us.html")); ``` The solution is to escape $ dolar signs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:45:52 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#328
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?