[PR #290] [MERGED] Fix to compile on MSVC 17.14.7 #288

New issue

Closed

opened 2026-05-05 03:44:53 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:44:53 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/290
Author: @klugier
Created: 7/5/2025
Status: ✅ Merged
Merged: 9/16/2025
Merged by: @mirek-fidler

Base: master ← Head: klugier/msvc-17.14.7-compilation-fixes

📝 Commits (1)

dad6fd3 Fix to compile on MSVC 17.14.7

📊 Changes

11 files changed (+14 additions, -14 deletions)

View changed files

📝 uppsrc/ide/Android/AndroidNDK.cpp (+3 -3)
📝 uppsrc/ide/Assist.cpp (+1 -1)
📝 uppsrc/ide/Builders/MakeFile.cpp (+1 -1)
📝 uppsrc/ide/Core/Util.cpp (+1 -1)
📝 uppsrc/ide/Debuggers/Pretty.cpp (+1 -1)
📝 uppsrc/ide/LayDes/fontprop.cpp (+1 -1)
📝 uppsrc/ide/LayDes/property.cpp (+1 -1)
📝 uppsrc/ide/MacroManager/UscFileParser.cpp (+2 -2)
📝 uppsrc/ide/Methods.cpp (+1 -1)
📝 uppsrc/ide/UppHub.cpp (+1 -1)
📝 uppsrc/ide/clang/Visitor.cpp (+1 -1)

📄 Description

It looks like something changed in the latest version of MSVC. Now there is a compilation error in teneray operation and strings. It might be bug in the compiler since this code compiles well for ages and there is no issue at all on other compilers.

The good news is that the fixed code is compatible with other compilers, too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/290 **Author:** [@klugier](https://github.com/klugier) **Created:** 7/5/2025 **Status:** ✅ Merged **Merged:** 9/16/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/msvc-17.14.7-compilation-fixes` --- ### 📝 Commits (1) - [`dad6fd3`](https://github.com/ultimatepp/ultimatepp/commit/dad6fd310acf0787c681ebb026e21e7c944db991) Fix to compile on MSVC 17.14.7 ### 📊 Changes **11 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/ide/Android/AndroidNDK.cpp` (+3 -3) 📝 `uppsrc/ide/Assist.cpp` (+1 -1) 📝 `uppsrc/ide/Builders/MakeFile.cpp` (+1 -1) 📝 `uppsrc/ide/Core/Util.cpp` (+1 -1) 📝 `uppsrc/ide/Debuggers/Pretty.cpp` (+1 -1) 📝 `uppsrc/ide/LayDes/fontprop.cpp` (+1 -1) 📝 `uppsrc/ide/LayDes/property.cpp` (+1 -1) 📝 `uppsrc/ide/MacroManager/UscFileParser.cpp` (+2 -2) 📝 `uppsrc/ide/Methods.cpp` (+1 -1) 📝 `uppsrc/ide/UppHub.cpp` (+1 -1) 📝 `uppsrc/ide/clang/Visitor.cpp` (+1 -1) </details> ### 📄 Description It looks like something changed in the latest version of MSVC. Now there is a compilation error in teneray operation and strings. It might be bug in the compiler since this code compiles well for ages and there is no issue at all on other compilers. The good news is that the fixed code is compatible with other compilers, too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:44:53 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#288

No description provided.

Rows
Columns