github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 06:05:58 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #279] [MERGED] Fix MSVC linking error due to wrong titlebar global variables declaration #284

New issue
Closed
opened 2026-05-05 03:44:46 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:44:46 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/279
Author: @klugier
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/9/2025
Merged by: @mirek-fidler

Base: master ← Head: klugier/fix-msvc-compilation

📝 Commits (3)

  • f741203 Fix MSVC compilation due to wrong titlebar global variables declarations.
  • 2b4707f Fix CustomTitleBar example
  • c7a9b63 Added description to CustomTitleBar example

📊 Changes

3 files changed (+6 additions, -5 deletions)

View changed files

📝 reference/CustomTitleBar/CustomTitleBar.upp (+2 -0)
📝 reference/CustomTitleBar/main.cpp (+1 -1)
📝 uppsrc/CtrlCore/Win32Wnd.cpp (+3 -4)

📄 Description

It looks like MSVC failed to link recent version of CtrlCore.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/279 **Author:** [@klugier](https://github.com/klugier) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/9/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/fix-msvc-compilation` --- ### 📝 Commits (3) - [`f741203`](https://github.com/ultimatepp/ultimatepp/commit/f74120388038b2a24e48b1594c1e4687096c1950) Fix MSVC compilation due to wrong titlebar global variables declarations. - [`2b4707f`](https://github.com/ultimatepp/ultimatepp/commit/2b4707f8572d4c5058ab1b8f43183b6a0ba53e25) Fix CustomTitleBar example - [`c7a9b63`](https://github.com/ultimatepp/ultimatepp/commit/c7a9b631914002f8a9af549ca564514e495f014f) Added description to CustomTitleBar example ### 📊 Changes **3 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `reference/CustomTitleBar/CustomTitleBar.upp` (+2 -0) 📝 `reference/CustomTitleBar/main.cpp` (+1 -1) 📝 `uppsrc/CtrlCore/Win32Wnd.cpp` (+3 -4) </details> ### 📄 Description It looks like MSVC failed to link recent version of CtrlCore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:44:46 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#284
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?