[PR #271] [CLOSED] Fix compilation issue in CodeEditor/Style.cpp on NixOS #282

New issue

Closed

opened 2026-05-05 03:44:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:44:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/271
Author: @klugier
Created: 5/25/2025
Status: ❌ Closed

Base: master ← Head: klugier/InitOnce-FixCompilationIssueOnNix

📝 Commits (1)

db5cad6 Update Style.cpp

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CodeEditor/Style.cpp (+1 -1)

📄 Description

It looks like inline in CodeEditor/Style.cpp is generating compilation error to on of our users o NixOS (https://nixos.org/).

What is worth noticing is than in .h file this function is without inline declaration - 522ccf5de0/uppsrc/CodeEditor/Syntax.h (L65).

		-lz -Wl,--end-group
/nix/store/wcv8n2k53w8sbffpf716gxj6mjb5jf26-binutils-2.44/bin/ld: .cache/upp.out/CodeEditor/GCC-Gcc-Gui-Linux-Posix-Shared/CodeEditor.a(CodeEditor.o): in function `Upp::CodeEditor::CodeEditor()':
CodeEditor.cpp:(.text._ZN3Upp10CodeEditorC2Ev+0x507): undefined reference to `Upp::HighlightSetup::InitOnce()'
collect2: error: ld returned 1 exit status
make: *** [Makefile:267: ide] Error 1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/271 **Author:** [@klugier](https://github.com/klugier) **Created:** 5/25/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/InitOnce-FixCompilationIssueOnNix` --- ### 📝 Commits (1) - [`db5cad6`](https://github.com/ultimatepp/ultimatepp/commit/db5cad68673f9571e6571116e0570e22e3e44fe8) Update Style.cpp ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CodeEditor/Style.cpp` (+1 -1) </details> ### 📄 Description It looks like inline in CodeEditor/Style.cpp is generating compilation error to on of our users o NixOS (https://nixos.org/). What is worth noticing is than in .h file this function is without inline declaration - https://github.com/ultimatepp/ultimatepp/blob/522ccf5de056b44cec6840a10e571085ec53ba6a/uppsrc/CodeEditor/Syntax.h#L65. ``` -lz -Wl,--end-group /nix/store/wcv8n2k53w8sbffpf716gxj6mjb5jf26-binutils-2.44/bin/ld: .cache/upp.out/CodeEditor/GCC-Gcc-Gui-Linux-Posix-Shared/CodeEditor.a(CodeEditor.o): in function `Upp::CodeEditor::CodeEditor()': CodeEditor.cpp:(.text._ZN3Upp10CodeEditorC2Ev+0x507): undefined reference to `Upp::HighlightSetup::InitOnce()' collect2: error: ld returned 1 exit status make: *** [Makefile:267: ide] Error 1 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:44:45 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#282

No description provided.

Rows
Columns