github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #238] [MERGED] CtrlCore: Fix issue with nested menubars on Wayland #258

New issue
Closed
opened 2026-05-05 03:44:09 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:44:09 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/238
Author: @klugier
Created: 3/15/2025
Status: ✅ Merged
Merged: 3/17/2025
Merged by: @mirek-fidler

Base: master ← Head: klugier/wayland-popups

📝 Commits (2)

  • 4ccc6a7 CtrlCore: Fix issue with nested menubars on Wayland.
  • 81b9857 Comment less invasive

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 uppsrc/CtrlCore/GtkCapture.cpp (+4 -2)

📄 Description

This change fix the issue with lack of focus for nested menubars on Wayland. The issue was caused by unnecessary call to GrabMouse() function on Wayland. Moreover in GTK4 gdk_seat_grab and gdk_device_grab were removed (https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-grabs). So, sooner or later we should stop using them.

This is safe fix and I recommend it for 2025.1. It only affects Wayland, For X11 everything is the same.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/238 **Author:** [@klugier](https://github.com/klugier) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/17/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/wayland-popups` --- ### 📝 Commits (2) - [`4ccc6a7`](https://github.com/ultimatepp/ultimatepp/commit/4ccc6a78ffe89dcf380917b55995fb08c3783626) CtrlCore: Fix issue with nested menubars on Wayland. - [`81b9857`](https://github.com/ultimatepp/ultimatepp/commit/81b985710e371e2d11b5eb0fffbf845338e6cfb0) Comment less invasive ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/GtkCapture.cpp` (+4 -2) </details> ### 📄 Description This change fix the issue with lack of focus for nested menubars on Wayland. The issue was caused by unnecessary call to GrabMouse() function on Wayland. Moreover in GTK4 gdk_seat_grab and gdk_device_grab were removed (https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-grabs). So, sooner or later we should stop using them. This is safe fix and I recommend it for 2025.1. It only affects Wayland, For X11 everything is the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:44:09 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#258
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?