[PR #230] [MERGED] Umk: Git exe file path fix for windows builds. #251

New issue

Closed

opened 2026-05-05 03:44:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:44:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/230
Author: @ismail-yilmaz
Created: 2/1/2025
Status: ✅ Merged
Merged: 2/2/2025
Merged by: @mirek-fidler

Base: master ← Head: umk_git_fix

📝 Commits (1)

98afc67 Umk: Git exe file path fix for windows builds.

📊 Changes

4 files changed (+22 additions, -6 deletions)

View changed files

📝 uppsrc/ide/Builders/CppBuilder.cpp (+4 -3)
📝 uppsrc/ide/Core/Core.h (+1 -0)
📝 uppsrc/ide/Core/Util.cpp (+14 -0)
📝 uppsrc/umk/UppHub.cpp (+3 -3)

📄 Description

This PR addresses the Git executable path issue on Windows. (See: issue #220)

Problem

Currently, umk uses only "git" as the executable path on both POSIX systems and Windows. While this works fine on POSIX, it causes issues on Windows because the system searches for Git in system directories. If Git is not installed globally, umk fails to perform Git-related operations (e.g., UppHub).

Solution

Since mingit is shipped by default, umk should first attempt to locate its executable, assuming it resides in a path relative to umk's executable folder.

This PR introduces a function: GetGitPath(), which:

First checks for mingit’s executable.
If not found, falls back to the default "git" executable.

This ensures umk can reliably use Git on Windows.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/230 **Author:** [@ismail-yilmaz](https://github.com/ismail-yilmaz) **Created:** 2/1/2025 **Status:** ✅ Merged **Merged:** 2/2/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `umk_git_fix` --- ### 📝 Commits (1) - [`98afc67`](https://github.com/ultimatepp/ultimatepp/commit/98afc674c4d9588a0740a03086c75cec33a0193b) Umk: Git exe file path fix for windows builds. ### 📊 Changes **4 files changed** (+22 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/ide/Builders/CppBuilder.cpp` (+4 -3) 📝 `uppsrc/ide/Core/Core.h` (+1 -0) 📝 `uppsrc/ide/Core/Util.cpp` (+14 -0) 📝 `uppsrc/umk/UppHub.cpp` (+3 -3) </details> ### 📄 Description This PR addresses the Git executable path issue on Windows. (See: issue #220) ### **Problem** Currently, **umk** uses only `"git"` as the executable path on both POSIX systems and Windows. While this works fine on POSIX, it causes issues on Windows because the system searches for Git in system directories. If Git is not installed globally, **umk** fails to perform Git-related operations (e.g., UppHub). ### **Solution** Since **mingit** is shipped by default, **umk** should first attempt to locate its executable, assuming it resides in a path relative to **umk**'s executable folder. This PR introduces a function: **`GetGitPath()`**, which: 1. First checks for **mingit’s** executable. 2. If not found, falls back to the default `"git"` executable. This ensures **umk** can reliably use Git on Windows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>