[PR #226] [MERGED] Fix a long-standing keyboard shortcuts parsing error. #245

New issue

Closed

opened 2026-05-05 03:43:53 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:43:53 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/226
Author: @ismail-yilmaz
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @mirek-fidler

Base: master ← Head: kbd_shortcut_fix

📝 Commits (1)

2173439 Keyboard shortcut fix.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlLib/AKeys.cpp (+1 -1)

📄 Description

This one-line patch aims to fix a long-standing bug in the keyboard shortcut parser.

Problem: Currently it is impossible to use Page Up, Page Down and Caps Lock keys (or any combination of these keys with modifier keys) as programmable keyboard shortcuts.
Reason: Keyboard shortcut parser creates a map of existing accelarator keys, using the KeyNames__ map, defined in CtrlCore/CtrlKbd.cpp:383. However, the textual representation of the above mentioned keys contain a space character, which the keyboard shortcut parser in CtrlLib/AKeys.cpp:238 does not like.
Solution: Filter out the space characters when building the map (which is only used for keyboard shortcuts.)
See the reference/AK example to reproduce the error. It is always reproducible.

This shouldn't break anything.

Please check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/226 **Author:** [@ismail-yilmaz](https://github.com/ismail-yilmaz) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `kbd_shortcut_fix` --- ### 📝 Commits (1) - [`2173439`](https://github.com/ultimatepp/ultimatepp/commit/21734398d0b46918be798a9b04cb20c20b491723) Keyboard shortcut fix. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/AKeys.cpp` (+1 -1) </details> ### 📄 Description This one-line patch aims to fix a long-standing bug in the keyboard shortcut parser. - `Problem`: Currently it is impossible to use `Page Up`, `Page Down` and `Caps Lock` keys (or any combination of these keys with modifier keys) as programmable keyboard shortcuts. - `Reason`: Keyboard shortcut parser creates a map of existing accelarator keys, using the `KeyNames__` map, defined in `CtrlCore/CtrlKbd.cpp:383`. However, the textual representation of the above mentioned keys contain a space character, which the keyboard shortcut parser in `CtrlLib/AKeys.cpp:238` does not like. - `Solution`: Filter out the space characters when building the map (which is only used for keyboard shortcuts.) - See the `reference/AK` example to reproduce the error. It is always reproducible. This shouldn't break anything. Please check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>