[PR #179] [CLOSED] Added verification and error handling for GCC builder when compiler doesn't exist #209

New issue

Closed

opened 2026-05-05 03:43:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:43:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/179
Author: @klugier
Created: 12/10/2023
Status: ❌ Closed

Base: master ← Head: klugier/gcc-compiler-no-present-error

📝 Commits (1)

b0a4a89 Added verification and error handling for Gcc builder when compiler executable doesn't exist.

📊 Changes

2 files changed (+16 additions, -0 deletions)

View changed files

📝 uppsrc/ide/Builders/Builders.h (+1 -0)
📝 uppsrc/ide/Builders/GccBuilder.cpp (+15 -0)

📄 Description

In the current GCC build algorithm, there is no clear indicator that the compiler executable doesn't exist. For example, let's assume that I typed "g+++" instead of "g++." In this case, there will be output on the compilation, but details about why it failed won't be present.

To mitigate this issue, there is a need to add a simple check at the beginning of the GccBuilder::BuildPackage method.

Output with change:

Saving 
----- ide/Builders ( GCC POSIX LINUX ) (1 / 12)
Error: Failed to find the 'aarch64-linux-gnu-c++a' compiler executable! Make sure the compiler is installed and is present in the executables path.

There were errors. (0:00.00)

Output before:

Saving 
----- ide/Builders ( GCC POSIX LINUX ) (1 / 12)
CppBuilder.cpp
MakeFile.cpp
CCJ.cpp
GccBuilder.cpp
MscBuilder.cpp
JavaBuilder.cpp
ScriptBuilder.cpp
Cocoa.cpp
AndroidProject.cpp
AndroidApplicationMakeFile.cpp
AndroidMakeFile.cpp
AndroidModuleMakeFile.cpp
AndroidBuilder.cpp
AndroidBuilderCommands.cpp
AndroidBuilderUtils.cpp
AndroidModuleMakeFileBuilder.cpp
Blitz.cpp
Build.cpp
Install.cpp
BuilderUtils.cpp

There were errors. (0:00.04)

In the above output the root cause is unknown.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/179 **Author:** [@klugier](https://github.com/klugier) **Created:** 12/10/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/gcc-compiler-no-present-error` --- ### 📝 Commits (1) - [`b0a4a89`](https://github.com/ultimatepp/ultimatepp/commit/b0a4a89e3b8962e171b2dd936af66bc433d1cb0e) Added verification and error handling for Gcc builder when compiler executable doesn't exist. ### 📊 Changes **2 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/ide/Builders/Builders.h` (+1 -0) 📝 `uppsrc/ide/Builders/GccBuilder.cpp` (+15 -0) </details> ### 📄 Description In the current GCC build algorithm, there is no clear indicator that the compiler executable doesn't exist. For example, let's assume that I typed "g+++" instead of "g++." In this case, there will be output on the compilation, but details about why it failed won't be present. To mitigate this issue, there is a need to add a simple check at the beginning of the GccBuilder::BuildPackage method. Output with change: ``` Saving ----- ide/Builders ( GCC POSIX LINUX ) (1 / 12) Error: Failed to find the 'aarch64-linux-gnu-c++a' compiler executable! Make sure the compiler is installed and is present in the executables path. There were errors. (0:00.00) ``` Output before: ``` Saving ----- ide/Builders ( GCC POSIX LINUX ) (1 / 12) CppBuilder.cpp MakeFile.cpp CCJ.cpp GccBuilder.cpp MscBuilder.cpp JavaBuilder.cpp ScriptBuilder.cpp Cocoa.cpp AndroidProject.cpp AndroidApplicationMakeFile.cpp AndroidMakeFile.cpp AndroidModuleMakeFile.cpp AndroidBuilder.cpp AndroidBuilderCommands.cpp AndroidBuilderUtils.cpp AndroidModuleMakeFileBuilder.cpp Blitz.cpp Build.cpp Install.cpp BuilderUtils.cpp There were errors. (0:00.04) ``` In the above output the root cause is unknown. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>