[PR #175] [CLOSED] UMK auto Upphub download doesn't work when there are more than one UppHub package #205

New issue

Closed

opened 2026-05-05 03:42:58 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:42:58 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/175
Author: @klugier
Created: 11/27/2023
Status: ❌ Closed

Base: master ← Head: klugier/umk-multiple-upphub-packages-fix

📝 Commits (1)

8366998 Update UppHub.cpp

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/umk/UppHub.cpp (+1 -1)

📄 Description

I have a problem with compiling following project with UMK -h option:

uses
	CtrlLib,
	Terminal,
	PtyProcess;

file
	main.cpp;

mainconfig
	"" = "GUI";

Please keep in mind that there are two packages from UppHub "Terminal" and "PtyProcess". When I declare only one of them UMK works when expected, when there are two of them then there is a problem.

I found a solution in line umk/UppHub.cpp line 184. You just need to chagne && to || and then everything works as expected. Please verify since I am not very sure about this change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/175 **Author:** [@klugier](https://github.com/klugier) **Created:** 11/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/umk-multiple-upphub-packages-fix` --- ### 📝 Commits (1) - [`8366998`](https://github.com/ultimatepp/ultimatepp/commit/836699874144732f6ad469387e30330cf9905849) Update UppHub.cpp ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/umk/UppHub.cpp` (+1 -1) </details> ### 📄 Description I have a problem with compiling following project with UMK -h option: ``` uses CtrlLib, Terminal, PtyProcess; file main.cpp; mainconfig "" = "GUI"; ``` Please keep in mind that there are two packages from UppHub "Terminal" and "PtyProcess". When I declare only one of them UMK works when expected, when there are two of them then there is a problem. I found a solution in line umk/UppHub.cpp line 184. You just need to chagne && to || and then everything works as expected. Please verify since I am not very sure about this change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>