[PR #163] [MERGED] Update PopUpList.cpp #197

New issue

Closed

opened 2026-05-05 03:42:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:42:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/163
Author: @schutm
Created: 9/15/2023
Status: ✅ Merged
Merged: 10/24/2023
Merged by: @mirek-fidler

Base: master ← Head: patch-1

📝 Commits (2)

585c743 Update PopUpList.cpp
04888ec Merge branch 'ultimatepp:master' into patch-1

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlLib/PopUpList.cpp (+1 -1)

📄 Description

The height of the listitems in the dropdown shouldn't be determined by the font-size. It should be taken from the list it encapsulates. See below code for the reason:

DropList dl;
dl.SetLineCy(32);
dl.Add(String("1")).Add(String("2"));
dl.SetLineCy(0, 48);

in this case the first row will be drawn with height 48px and second with (on my machine) height 15px. This change ensure the second line will be drawn with height 32px.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/163 **Author:** [@schutm](https://github.com/schutm) **Created:** 9/15/2023 **Status:** ✅ Merged **Merged:** 10/24/2023 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`585c743`](https://github.com/ultimatepp/ultimatepp/commit/585c7438b571293056624ccad3e3e61f0bcb1f74) Update PopUpList.cpp - [`04888ec`](https://github.com/ultimatepp/ultimatepp/commit/04888eca719950ae14bb66f7c5ca1927e0652ef5) Merge branch 'ultimatepp:master' into patch-1 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/PopUpList.cpp` (+1 -1) </details> ### 📄 Description The height of the listitems in the dropdown shouldn't be determined by the font-size. It should be taken from the list it encapsulates. See below code for the reason: DropList dl; dl.SetLineCy(32); dl.Add(String("1")).Add(String("2")); dl.SetLineCy(0, 48); in this case the first row will be drawn with height 48px and second with (on my machine) height 15px. This change ensure the second line will be drawn with height 32px. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>