[PR #143] [MERGED] Editor overwrite mode fixes #185

New issue

Closed

opened 2026-05-05 03:42:31 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:42:31 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/143
Author: @ped7g
Created: 2/1/2023
Status: ✅ Merged
Merged: 2/5/2023
Merged by: @mirek-fidler

Base: master ← Head: editor_overwrite

📝 Commits (2)

d9efed9 uppsrc: enable (fix) overwrite also in non CLogic editors (txt, python, ...)
cf6657c uppsrc: use count in CSyntax IndentInsert0 regular char insert

📊 Changes

5 files changed (+5 additions, -5 deletions)

View changed files

📝 uppsrc/CodeEditor/CLogic.cpp (+1 -1)
📝 uppsrc/CodeEditor/CodeEditor.cpp (+1 -1)
📝 uppsrc/CodeEditor/PythonSyntax.cpp (+1 -1)
📝 uppsrc/CodeEditor/Syntax.cpp (+1 -1)
📝 uppsrc/CodeEditor/TagSyntax.cpp (+1 -1)

📄 Description

Overwrite worked only in CSyntax files, failed in txt, etc..

second commit: seems to me there was ignored count argument in CSyntax::IndentInsert0 - I'm not sure how test this and where count > 1 can emerge, but seems to me like bug.

Please review, I don't understand all possible code paths how these can be triggered, and why the canoverwrite argument even was added in the first place (as InsertChar itself does ignore overwrite for certain characters like newline), so I tried my best guess where the canoverwrite change should be harmless, but I have no deep understanding.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/143 **Author:** [@ped7g](https://github.com/ped7g) **Created:** 2/1/2023 **Status:** ✅ Merged **Merged:** 2/5/2023 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `editor_overwrite` --- ### 📝 Commits (2) - [`d9efed9`](https://github.com/ultimatepp/ultimatepp/commit/d9efed94168b5d6c36a059d5e75d5fa446a7d37f) uppsrc: enable (fix) overwrite also in non CLogic editors (txt, python, ...) - [`cf6657c`](https://github.com/ultimatepp/ultimatepp/commit/cf6657c4df948be61322d841e114bde86af20ca1) uppsrc: use count in CSyntax IndentInsert0 regular char insert ### 📊 Changes **5 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CodeEditor/CLogic.cpp` (+1 -1) 📝 `uppsrc/CodeEditor/CodeEditor.cpp` (+1 -1) 📝 `uppsrc/CodeEditor/PythonSyntax.cpp` (+1 -1) 📝 `uppsrc/CodeEditor/Syntax.cpp` (+1 -1) 📝 `uppsrc/CodeEditor/TagSyntax.cpp` (+1 -1) </details> ### 📄 Description Overwrite worked only in CSyntax files, failed in txt, etc.. second commit: seems to me there was ignored `count` argument in CSyntax::IndentInsert0 - I'm not sure how test this and where `count > 1` can emerge, but seems to me like bug. Please review, I don't understand all possible code paths how these can be triggered, and why the `canoverwrite` argument even was added in the first place (as InsertChar itself does ignore overwrite for certain characters like newline), so I tried my best guess where the canoverwrite change should be harmless, but I have no deep understanding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:42:31 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#185

No description provided.

Rows
Columns