github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #122] [CLOSED] ClangFormat integration #171

New issue
Closed
opened 2026-05-05 03:42:08 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:42:08 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/122
Author: @klugier
Created: 12/24/2022
Status: ❌ Closed

Base: master ← Head: klugier/clang-format-itnegration

📝 Commits (10+)

📊 Changes

12 files changed (+398 additions, -50 deletions)

View changed files

➕ .clang-format (+24 -0)
📝 uppsrc/ide/Android/AndroidManifest.cpp (+2 -1)
📝 uppsrc/ide/Builders/Build.cpp (+3 -3)
📝 uppsrc/ide/Core/Host.cpp (+14 -2)
📝 uppsrc/ide/Core/Host.h (+1 -0)
📝 uppsrc/ide/FormatCode.cpp (+311 -15)
📝 uppsrc/ide/NewPackageFile.cpp (+7 -3)
📝 uppsrc/ide/ide.h (+5 -2)
📝 uppsrc/ide/ide.key (+4 -9)
📝 uppsrc/ide/ide.upp (+1 -1)
📝 uppsrc/ide/idebar.cpp (+26 -9)
📝 uppsrc/ide/idetool.cpp (+0 -5)

📄 Description

In this PR following things has been added/modified:

  • Rework of TheIDE's menu bar. Right now there is a separated "Reformat" menu that are available in "Edit" and "Assist" menus. ALT+SHIFT+R is the shortcut for invoking reformat command.
  • The possibility to reformat XML/JSON outside code editor has been removed. It is duplicated functionality we currently have. For more details please see Ide::FormatJSON_XML_File method deletion (FormatCode.cpp).
  • Full integration with clang-format binary.
  • New File dialog now allows to create .clang-format configuration file
  • Default style available in the repository root directory basing on the style present in U++ source files

@mirek-fidler please review if this change is going into the good direction. The code responsible for calling clang-format executable will be implemented later. I would like to avoid situation when we will do not agree on this initial changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/122 **Author:** [@klugier](https://github.com/klugier) **Created:** 12/24/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/clang-format-itnegration` --- ### 📝 Commits (10+) - [`a95d2bb`](https://github.com/ultimatepp/ultimatepp/commit/a95d2bb993790d5fa32428828a75c0759be908b9) Developing clang-format integration. - [`c310b7e`](https://github.com/ultimatepp/ultimatepp/commit/c310b7ec83a831e61d11e4d2442c1b21f6496812) Merge branch 'master' of https://github.com/ultimatepp/ultimatepp into klugier/clang-format-itnegration - [`42116fe`](https://github.com/ultimatepp/ultimatepp/commit/42116feb3ad625f46747452ac6ccc547e2f38b36) Added reformat menu. - [`509bd0c`](https://github.com/ultimatepp/ultimatepp/commit/509bd0ce73bf65073a59c33b04831095cc6c4455) Removed duplicated options related to format JSON and XML. - [`7b65ed6`](https://github.com/ultimatepp/ultimatepp/commit/7b65ed68a1a2d513b61b2097eb7302f2b4c72669) Merge branch 'master' of https://github.com/ultimatepp/ultimatepp into klugier/clang-format-itnegration - [`736cab4`](https://github.com/ultimatepp/ultimatepp/commit/736cab418a0f7d53b94c4114e95e8b78693f54b6) Merge branch 'master' of https://github.com/ultimatepp/ultimatepp into klugier/clang-format-itnegration - [`04ae69c`](https://github.com/ultimatepp/ultimatepp/commit/04ae69ccde12b701e837eebad22a36f3ec65648b) Initial clang-format integration. - [`d1c8523`](https://github.com/ultimatepp/ultimatepp/commit/d1c85237868ea52975039264eeaf71eb15b0e0eb) Added global .clang-format file to the repository. - [`ff81ddc`](https://github.com/ultimatepp/ultimatepp/commit/ff81ddcdcf1fffed8a172201741eaa1646912a48) Update .clang-format style - [`e2156de`](https://github.com/ultimatepp/ultimatepp/commit/e2156ded4e0fbcf906e46b702f9d549b711e9d8f) Working on clang-format integration. ### 📊 Changes **12 files changed** (+398 additions, -50 deletions) <details> <summary>View changed files</summary> ➕ `.clang-format` (+24 -0) 📝 `uppsrc/ide/Android/AndroidManifest.cpp` (+2 -1) 📝 `uppsrc/ide/Builders/Build.cpp` (+3 -3) 📝 `uppsrc/ide/Core/Host.cpp` (+14 -2) 📝 `uppsrc/ide/Core/Host.h` (+1 -0) 📝 `uppsrc/ide/FormatCode.cpp` (+311 -15) 📝 `uppsrc/ide/NewPackageFile.cpp` (+7 -3) 📝 `uppsrc/ide/ide.h` (+5 -2) 📝 `uppsrc/ide/ide.key` (+4 -9) 📝 `uppsrc/ide/ide.upp` (+1 -1) 📝 `uppsrc/ide/idebar.cpp` (+26 -9) 📝 `uppsrc/ide/idetool.cpp` (+0 -5) </details> ### 📄 Description In this PR following things has been added/modified: - Rework of TheIDE's menu bar. Right now there is a separated "Reformat" menu that are available in "Edit" and "Assist" menus. ALT+SHIFT+R is the shortcut for invoking reformat command. - The possibility to reformat XML/JSON outside code editor has been removed. It is duplicated functionality we currently have. For more details please see Ide::FormatJSON_XML_File method deletion (FormatCode.cpp). - Full integration with clang-format binary. - New File dialog now allows to create .clang-format configuration file - Default style available in the repository root directory basing on the style present in U++ source files @mirek-fidler please review if this change is going into the good direction. The code responsible for calling clang-format executable will be implemented later. I would like to avoid situation when we will do not agree on this initial changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:42:08 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#171
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?