[PR #119] [CLOSED] possible fix #169

New issue

Closed

opened 2026-05-05 03:42:03 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:42:03 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/119
Author: @ped7g
Created: 12/13/2022
Status: ❌ Closed

Base: master ← Head: small_changes

📝 Commits (2)

d74ad77 ide: possible OOB access into sOperatorTab with signed-char index -128..-1
e42c208 Core: fix unused variable s by using it

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 uppsrc/Core/Mt.cpp (+2 -2)
📝 uppsrc/ide/clang/Signature.cpp (+2 -2)

📄 Description

Seems you left out the most important change to fix the sOperatorTab access with signed char.

Was that intentional? To me it looks like logical fix, although I didn't verify how to trigger the bug by source code.

(the change in Mt.cpp is not important, but the Signature.cpp IMO is)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/119 **Author:** [@ped7g](https://github.com/ped7g) **Created:** 12/13/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `small_changes` --- ### 📝 Commits (2) - [`d74ad77`](https://github.com/ultimatepp/ultimatepp/commit/d74ad77f24db36d55ad43be8943cb919ee948186) ide: possible OOB access into sOperatorTab with signed-char index -128..-1 - [`e42c208`](https://github.com/ultimatepp/ultimatepp/commit/e42c20881fac2ba5a1361d8bd3b6e81268e0be78) Core: fix unused variable `s` by using it ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Core/Mt.cpp` (+2 -2) 📝 `uppsrc/ide/clang/Signature.cpp` (+2 -2) </details> ### 📄 Description Seems you left out the most important change to fix the `sOperatorTab` access with signed char. Was that intentional? To me it looks like logical fix, although I didn't verify how to trigger the bug by source code. (the change in Mt.cpp is not important, but the Signature.cpp IMO is) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>