[PR #98] [MERGED] Fix for blank dialog icons in standard dialogs on GTK backend #151

New issue

Closed

opened 2026-05-05 03:41:39 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:41:39 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/98
Author: @klugier
Created: 9/26/2022
Status: ✅ Merged
Merged: 9/30/2022
Merged by: @mirek-fidler

Base: master ← Head: klugier/fix-dialog-icons-gtk

📝 Commits (4)

dc3f47b CtrlLib: Dialog icons are now loaded correctly for newer GTK version.
bdc8831 CtrlLib: if loading dialog icon failed do not replace image.
652b245 .cosmetics
7c26e7d .cosmetic in comment

📊 Changes

1 file changed (+24 additions, -11 deletions)

View changed files

📝 uppsrc/CtrlLib/ChGtk3.cpp (+24 -11)

📄 Description

Since GTK version 3.10 icons names for dialog elements such as information, warning, error and exclamations has been deprecated. On newest version our current loading approach doesn't work at all. To eliminate the issue we need new theme string for GTK version 3.10 and above.

What's new:

dedicated code for loading dialog icon for GTK version 3.10 and above
more secure approach of loading GTK icons, if it fails stock icons are used instead of null one

We can remove if statment completly if we do not want to support GTK priori to version 3.10. 3.10 version was release on 2013-09-23. There is very little chances that some distribution are using it even with long term support.

Information about deprecation can be find here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/98 **Author:** [@klugier](https://github.com/klugier) **Created:** 9/26/2022 **Status:** ✅ Merged **Merged:** 9/30/2022 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/fix-dialog-icons-gtk` --- ### 📝 Commits (4) - [`dc3f47b`](https://github.com/ultimatepp/ultimatepp/commit/dc3f47b873134b290c1deb428d0864263aae6abc) CtrlLib: Dialog icons are now loaded correctly for newer GTK version. - [`bdc8831`](https://github.com/ultimatepp/ultimatepp/commit/bdc8831d8a26ec62e0d6b8fbee2cbf960ca9b968) CtrlLib: if loading dialog icon failed do not replace image. - [`652b245`](https://github.com/ultimatepp/ultimatepp/commit/652b2457b503dd290e51c10188207a9369fcb521) .cosmetics - [`7c26e7d`](https://github.com/ultimatepp/ultimatepp/commit/7c26e7df2ce47b94ebb1ac27e2a456f7611a5d08) .cosmetic in comment ### 📊 Changes **1 file changed** (+24 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/ChGtk3.cpp` (+24 -11) </details> ### 📄 Description Since GTK version 3.10 icons names for dialog elements such as information, warning, error and exclamations has been deprecated. On newest version our current loading approach doesn't work at all. To eliminate the issue we need new theme string for GTK version 3.10 and above. What's new: - dedicated code for loading dialog icon for GTK version 3.10 and above - more secure approach of loading GTK icons, if it fails stock icons are used instead of null one We can remove if statment completly if we do not want to support GTK priori to version 3.10. 3.10 version was release on 2013-09-23. There is very little chances that some distribution are using it even with long term support. Information about deprecation can be find [here](https://docs.gtk.org/gtk3/const.STOCK_DIALOG_INFO.html). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:41:39 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#151

No description provided.

Rows
Columns