github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #97] [MERGED] Fixed issue with wrong text color on selected menu item (Win11) #150

New issue
Closed
opened 2026-05-05 03:41:39 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:41:39 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/97
Author: @klugier
Created: 9/21/2022
Status: ✅ Merged
Merged: 9/22/2022
Merged by: @mirek-fidler

Base: master ← Head: klugier/win11-menu-tem-color-fix

📝 Commits (1)

  • 1a3078e Fixed issue with wrong text color on selected menu item.

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 uppsrc/CtrlLib/ChWin32.cpp (+3 -2)

📄 Description

Windows 11 default them treats MENU_BARITEM and MENU_POPUPITEM differently. In the current CtrlLib implementation we always read value from the first thing, which is not always accurate and cause issue like invisible text in selected items in menubar. It can be improved by chaining code responsible for reading system theme.

Without fix (Win11):
MenuBarWrongColorWin11

After fix (Win11):
MenuBarFix

Mirek, if you will be merging this please verify on Windows 10. I think everything should be fine, but it is definitely worth checking. Thanks!

For comparison reason, this is screenshot from the desktop menubar:
MenuBarDesktop

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/97 **Author:** [@klugier](https://github.com/klugier) **Created:** 9/21/2022 **Status:** ✅ Merged **Merged:** 9/22/2022 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/win11-menu-tem-color-fix` --- ### 📝 Commits (1) - [`1a3078e`](https://github.com/ultimatepp/ultimatepp/commit/1a3078e6bbfa09d2a1dd29f93a44d456164bece7) Fixed issue with wrong text color on selected menu item. ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/ChWin32.cpp` (+3 -2) </details> ### 📄 Description Windows 11 default them treats MENU_BARITEM and MENU_POPUPITEM differently. In the current CtrlLib implementation we always read value from the first thing, which is not always accurate and cause issue like invisible text in selected items in menubar. It can be improved by chaining code responsible for reading system theme. Without fix (Win11): ![MenuBarWrongColorWin11](https://user-images.githubusercontent.com/6963025/191622693-32325d78-46a0-4f9d-9872-ff63f8c9a0f4.png) After fix (Win11): ![MenuBarFix](https://user-images.githubusercontent.com/6963025/191622287-bfd63614-9f72-493e-b7e5-06808bcea638.png) Mirek, if you will be merging this please verify on Windows 10. I think everything should be fine, but it is definitely worth checking. Thanks! ---------------------------------- For comparison reason, this is screenshot from the desktop menubar: ![MenuBarDesktop](https://user-images.githubusercontent.com/6963025/191849506-9622c826-3047-4b2f-98bd-18768e89a2a1.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:41:39 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#150
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?