[PR #59] [CLOSED] ScrollBar rewritten. #131

New issue

Closed

opened 2026-05-05 03:41:07 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:41:07 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/59
Author: @Lance219
Created: 12/30/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

0741797 Rewrite ScrollBar to get rid of prev/prev2/next/next2 Buttons.
57344a4 Rewrite ScrollBar to get rid of Button prev,prev2,next,next2;
86ac1db del ScrollBar.zip
ffaa1bc int HScrollBar::operator(int i) is indeed needed :(.
b711dc8 WhichSection () missed case section=1. Use plain simple method insread.
3d8acf0 Merge branch 'ultimatepp:master' into master
e4495dd Ctrl could benefit from rearrange data memeber to minimize padding & sizeof(Ctrl);
2d20b3d Rearrange order of member variables to (possibly) save on padding for some fundamental Upp classes.
d43ed5f Introduced debug mode variables to keep track of maximum number of ScrollBar used by the program that's being debugged.
bca61a7 Merge branch 'ultimatepp:master' into master

📊 Changes

3 files changed (+269 additions, -198 deletions)

View changed files

📝 uppsrc/CtrlCore/CtrlCore.h (+6 -1)
📝 uppsrc/CtrlLib/ScrollBar.cpp (+185 -173)
📝 uppsrc/CtrlLib/ScrollBar.h (+78 -24)

📄 Description

CtrlLib/ScrollBar is modified to get rid of the prev, prev2, next, next3 Buttons. The corresponding portion of the ScrollBar are painted used the similar logic that original code used to paint the 3 parts of Slider&Thumb. The code that's changed mainly involve painting and mouse event. No interface is changed, so the revision is transparent to libary users.

As a result of the revision. Now sizeof(ScrollBar)==sizeof(Button). Initial tests indicate that executable size also benefit from the revision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/59 **Author:** [@Lance219](https://github.com/Lance219) **Created:** 12/30/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`0741797`](https://github.com/ultimatepp/ultimatepp/commit/0741797fcd5589f0958549dc838a88db3ec6c96f) Rewrite ScrollBar to get rid of prev/prev2/next/next2 Buttons. - [`57344a4`](https://github.com/ultimatepp/ultimatepp/commit/57344a47b3cd2f7a4258ebc6dff14aa7bcdfb11d) Rewrite ScrollBar to get rid of Button prev,prev2,next,next2; - [`86ac1db`](https://github.com/ultimatepp/ultimatepp/commit/86ac1db71aa61117853081c8c444158025fe7592) del ScrollBar.zip - [`ffaa1bc`](https://github.com/ultimatepp/ultimatepp/commit/ffaa1bc096ac1633dd9d9fded9af0f9b313af07d) int HScrollBar::operator(int i) is indeed needed :(. - [`b711dc8`](https://github.com/ultimatepp/ultimatepp/commit/b711dc84a8fb69622a00dd8fe6ef9cca12219f18) WhichSection () missed case section=1. Use plain simple method insread. - [`3d8acf0`](https://github.com/ultimatepp/ultimatepp/commit/3d8acf039e62ad76b204c6a531bdac5bffd2de9e) Merge branch 'ultimatepp:master' into master - [`e4495dd`](https://github.com/ultimatepp/ultimatepp/commit/e4495dda837a3dea79d3a548eb8d59fc0fcac154) Ctrl could benefit from rearrange data memeber to minimize padding & sizeof(Ctrl); - [`2d20b3d`](https://github.com/ultimatepp/ultimatepp/commit/2d20b3d4f9ffb4fa9848dc01927b8a4e6e5e6c41) Rearrange order of member variables to (possibly) save on padding for some fundamental Upp classes. - [`d43ed5f`](https://github.com/ultimatepp/ultimatepp/commit/d43ed5f325b5719fdf74c9d5649c953d4e371336) Introduced debug mode variables to keep track of maximum number of ScrollBar used by the program that's being debugged. - [`bca61a7`](https://github.com/ultimatepp/ultimatepp/commit/bca61a720c1fafb764c334cb5b0afe903c719dbc) Merge branch 'ultimatepp:master' into master ### 📊 Changes **3 files changed** (+269 additions, -198 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/CtrlCore.h` (+6 -1) 📝 `uppsrc/CtrlLib/ScrollBar.cpp` (+185 -173) 📝 `uppsrc/CtrlLib/ScrollBar.h` (+78 -24) </details> ### 📄 Description `CtrlLib/ScrollBar` is modified to get rid of the `prev, prev2, next, next3` Buttons. The corresponding portion of the `ScrollBar` are painted used the similar logic that original code used to paint the 3 parts of Slider&Thumb. The code that's changed mainly involve painting and mouse event. No interface is changed, so the revision is transparent to libary users. As a result of the revision. Now `sizeof(ScrollBar)==sizeof(Button)`. Initial tests indicate that executable size also benefit from the revision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>