github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #21] [CLOSED] CtrlCore: Removing Turtle specific flags #117

New issue
Closed
opened 2026-05-05 03:40:44 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:40:44 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/21
Author: @ismail-yilmaz
Created: 9/8/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

  • b51da42 UppWeb: U++ technologies table of contents completed.
  • 7ee5274 CtrlLib, Doc: .cosmetics
  • c93ef5c Core, Doc: Core 2016 modernisation.
  • 08182a2 ide: LayDes .usc fixed ordering issue
  • 83c633d Core, Doc: NTL article modernization.
  • 65d102f UppWeb: Added missing TheIDE begginers guild into documentation.
  • 46c80d9 RichText, Doc: Added table of content to QTF and integrate it in Qtf designer.
  • 814e645 Ide: Added tooltips to QTF deisgner buttons.
  • efb2ebc ide: OnlineSearch improvements
  • de7066f CtrlLib, Doc: Added information about creating GUI packages from template in tutorial.

📊 Changes

1 file changed (+1 additions, -8 deletions)

View changed files

📝 uppsrc/CtrlCore/CtrlCore.h (+1 -8)

📄 Description

This pull request aims to remove the now obsolete TURTLE flags defined in CtrlCore.
The new Turtle package does not require these flags. It relies on VIRTUALGUI flag.

Note that there is one other TURTLE flag yet to be removed (or changed to VIRTUALGUI) (in Core/App.cpp):

0b2bd0a241/uppsrc/Core/App.cpp (L540-L549)

This needs to be handled carefully as it redefines Upp::LaunchWebBrowser global function on TURTLE backend.
(I think we should simply add a global WhenLaunchWebBrowser event in VIRTUALGUI: backend, and let clients handle it as they see fit.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/21 **Author:** [@ismail-yilmaz](https://github.com/ismail-yilmaz) **Created:** 9/8/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`b51da42`](https://github.com/ultimatepp/ultimatepp/commit/b51da429e4bdf496554dcea39f2f2e7511f0f30e) UppWeb: U++ technologies table of contents completed. - [`7ee5274`](https://github.com/ultimatepp/ultimatepp/commit/7ee5274239b782eb44a0413a35e1eb88ba9311b2) CtrlLib, Doc: .cosmetics - [`c93ef5c`](https://github.com/ultimatepp/ultimatepp/commit/c93ef5cac43940ab54002843a2c7105c090d5788) Core, Doc: Core 2016 modernisation. - [`08182a2`](https://github.com/ultimatepp/ultimatepp/commit/08182a2c1fcf402ef3187e58b562152adfd01a3d) ide: LayDes .usc fixed ordering issue - [`83c633d`](https://github.com/ultimatepp/ultimatepp/commit/83c633d06fa94aa7de9ba5f3f183e892a9443df9) Core, Doc: NTL article modernization. - [`65d102f`](https://github.com/ultimatepp/ultimatepp/commit/65d102f74f0372a81d5f7f103d22f5ddeb15f280) UppWeb: Added missing TheIDE begginers guild into documentation. - [`46c80d9`](https://github.com/ultimatepp/ultimatepp/commit/46c80d9521a65c2279b38a8cf951306c6bbf6379) RichText, Doc: Added table of content to QTF and integrate it in Qtf designer. - [`814e645`](https://github.com/ultimatepp/ultimatepp/commit/814e645e4e8ece726ca42653c9b7a4e697840a60) Ide: Added tooltips to QTF deisgner buttons. - [`efb2ebc`](https://github.com/ultimatepp/ultimatepp/commit/efb2ebcaa75d57879690be85a0866a827fc0e560) ide: OnlineSearch improvements - [`de7066f`](https://github.com/ultimatepp/ultimatepp/commit/de7066f119e87cd83f2b43bfd2c0f10e929df065) CtrlLib, Doc: Added information about creating GUI packages from template in tutorial. ### 📊 Changes **1 file changed** (+1 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/CtrlCore.h` (+1 -8) </details> ### 📄 Description This pull request aims to remove the now obsolete TURTLE flags defined in CtrlCore. The new Turtle package does not require these flags. It relies on VIRTUALGUI flag. Note that there is one other TURTLE flag yet to be removed (or changed to VIRTUALGUI) (in Core/App.cpp): https://github.com/ultimatepp/ultimatepp/blob/0b2bd0a24170d6b8af1cacc027fd3911f006fcb9/uppsrc/Core/App.cpp#L540-L549 This needs to be handled carefully as it redefines Upp::LaunchWebBrowser global function on TURTLE backend. (I think we should simply add a global WhenLaunchWebBrowser event in VIRTUALGUI: backend, and let clients handle it as they see fit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:40:44 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#117
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?