[PR #13] [CLOSED] SysInfo: fix MouseKey.cpp compile w/ NO_XTEST on non-Win32 platforms #112

New issue

Closed

opened 2026-05-05 03:40:36 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:40:36 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/13
Author: @erikjwaxx
Created: 3/5/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

a698aca SysInfo: fix MouseKey.cpp compile w/ NO_XTEST on non-Win32 platforms

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 bazaar/SysInfo/MouseKey.cpp (+1 -2)

📄 Description

The #if defined(PLATFORM_WIN32) || !defined(flagNO_XTEST) directive
was incorrectly #endif'd outside the namespace Upp block it was opened
in, leading to a syntactically invalid file with an unterminated
namespace block when this #ifdef is false.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/13 **Author:** [@erikjwaxx](https://github.com/erikjwaxx) **Created:** 3/5/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`a698aca`](https://github.com/ultimatepp/ultimatepp/commit/a698aca969f7ee831bf8bb51a3abe53291378d29) SysInfo: fix MouseKey.cpp compile w/ NO_XTEST on non-Win32 platforms ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bazaar/SysInfo/MouseKey.cpp` (+1 -2) </details> ### 📄 Description The `#if defined(PLATFORM_WIN32) || !defined(flagNO_XTEST)` directive was incorrectly `#endif`'d outside the `namespace Upp` block it was opened in, leading to a syntactically invalid file with an unterminated namespace block when this `#ifdef` is false. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>