[GH-ISSUE #27] TheIDE is not building and this can fix it #10

Closed
opened 2026-05-05 03:33:56 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @mingodad on GitHub (Jan 5, 2021).
Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/27

I just cloned this repo and when trying to build it stops with the error below and with the changes show bellow I could make it build:

c++ -c -x c++ -O3 -ffunction-sections -fdata-sections  -std=c++14 -I./uppsrc/ `pkg-config --cflags freetype2` `pkg-config --cflags x11` `pkg-config --cflags fontconfig` `pkg-config --cflags xcb` `pkg-config --cflags expat` `pkg-config --cflags xinerama` `pkg-config --cflags xrender` `pkg-config --cflags xft` `pkg-config --cflags xdmcp` `pkg-config --cflags xext` `pkg-config --cflags gtk+-3.0` `pkg-config --cflags libnotify` `pkg-config --cflags libpng` -I./ -I.cache/upp.out/ -DflagGUI -DflagGCC -DflagSHARED -DflagPOSIX -DflagLINUX -DflagMAIN  ./uppsrc/ide/Credentials.cpp -o .cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o
In file included from ./uppsrc/CtrlCore/CtrlCore.h:1685,
                 from ./uppsrc/CtrlLib/CtrlLib.h:4,
                 from ./uppsrc/ide/Common/Common.h:5,
                 from ./uppsrc/ide/ide.h:4,
                 from ./uppsrc/ide/Credentials.cpp:1:
./uppsrc/CtrlCore/TopWindow.h: In instantiation of ‘void Upp::CtrlLayoutOKCancel(T&, const char*) [with T = GetPasskeyDlg]’:
./uppsrc/ide/Credentials.cpp:97:37:   required from here
./uppsrc/CtrlCore/TopWindow.h:235:21: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’
  235 |  ctrl.Rejector(ctrl.cancel, IDCANCEL);
      |                ~~~~~^~~~~~
./uppsrc/CtrlCore/TopWindow.h:236:7: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’
  236 |  ctrl.cancel.Cancel();
      |  ~~~~~^~~~~~
./uppsrc/CtrlCore/TopWindow.h:237:32: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’
  237 |  ArrangeOKCancel(ctrl.ok, ctrl.cancel);
      |                           ~~~~~^~~~~~
Makefile:14356: recipe for target '.cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o' failed
make: *** [.cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o] Error 1
@@ -92,11 +92,11 @@ struct GetPasskeyDlg : WithGetPasskeyLayout<TopWindow> {
 	void Sync() { passkey.Password(!show_passkey); }
 };
 
 GetPasskeyDlg::GetPasskeyDlg()
 {
-	CtrlLayoutOKCancel(*this, "Passkey");
+	CtrlLayoutOK(*this, "Passkey");
 	
 	show_passkey << [=] { Sync(); };
 	
 	Sync();
 }
Originally created by @mingodad on GitHub (Jan 5, 2021). Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/27 I just cloned this repo and when trying to build it stops with the error below and with the changes show bellow I could make it build: ``` c++ -c -x c++ -O3 -ffunction-sections -fdata-sections -std=c++14 -I./uppsrc/ `pkg-config --cflags freetype2` `pkg-config --cflags x11` `pkg-config --cflags fontconfig` `pkg-config --cflags xcb` `pkg-config --cflags expat` `pkg-config --cflags xinerama` `pkg-config --cflags xrender` `pkg-config --cflags xft` `pkg-config --cflags xdmcp` `pkg-config --cflags xext` `pkg-config --cflags gtk+-3.0` `pkg-config --cflags libnotify` `pkg-config --cflags libpng` -I./ -I.cache/upp.out/ -DflagGUI -DflagGCC -DflagSHARED -DflagPOSIX -DflagLINUX -DflagMAIN ./uppsrc/ide/Credentials.cpp -o .cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o In file included from ./uppsrc/CtrlCore/CtrlCore.h:1685, from ./uppsrc/CtrlLib/CtrlLib.h:4, from ./uppsrc/ide/Common/Common.h:5, from ./uppsrc/ide/ide.h:4, from ./uppsrc/ide/Credentials.cpp:1: ./uppsrc/CtrlCore/TopWindow.h: In instantiation of ‘void Upp::CtrlLayoutOKCancel(T&, const char*) [with T = GetPasskeyDlg]’: ./uppsrc/ide/Credentials.cpp:97:37: required from here ./uppsrc/CtrlCore/TopWindow.h:235:21: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’ 235 | ctrl.Rejector(ctrl.cancel, IDCANCEL); | ~~~~~^~~~~~ ./uppsrc/CtrlCore/TopWindow.h:236:7: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’ 236 | ctrl.cancel.Cancel(); | ~~~~~^~~~~~ ./uppsrc/CtrlCore/TopWindow.h:237:32: error: ‘struct GetPasskeyDlg’ has no member named ‘cancel’ 237 | ArrangeOKCancel(ctrl.ok, ctrl.cancel); | ~~~~~^~~~~~ Makefile:14356: recipe for target '.cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o' failed make: *** [.cache/upp.out/ide/GCC-Gcc-Gui-Linux-Main-Posix-Shared/Credentials.o] Error 1 ``` ``` @@ -92,11 +92,11 @@ struct GetPasskeyDlg : WithGetPasskeyLayout<TopWindow> { void Sync() { passkey.Password(!show_passkey); } }; GetPasskeyDlg::GetPasskeyDlg() { - CtrlLayoutOKCancel(*this, "Passkey"); + CtrlLayoutOK(*this, "Passkey"); show_passkey << [=] { Sync(); }; Sync(); } ```
Author
Owner

@mingodad commented on GitHub (Jan 5, 2021):

Thinking a bit about it, probably the best fix is to add a Cancel button to GetPasskeyDlg.
And also check for the user select option !

<!-- gh-comment-id:754566007 --> @mingodad commented on GitHub (Jan 5, 2021): Thinking a bit about it, probably the best fix is to add a `Cancel` button to `GetPasskeyDlg`. And also check for the user select option !
Author
Owner

@klugier commented on GitHub (Jan 5, 2021):

Yes, we should definitely support cancellation. Here is the commit that breaks the build 9c0efcd795. @mirek-fidler can you look at this problem?

Of course many thanks for reporting problem!

<!-- gh-comment-id:754586905 --> @klugier commented on GitHub (Jan 5, 2021): Yes, we should definitely support cancellation. Here is the commit that breaks the build https://github.com/ultimatepp/ultimatepp/commit/9c0efcd795a07a4e019440a4ed497e97b3bbff95. @mirek-fidler can you look at this problem? Of course many thanks for reporting problem!
Author
Owner

@klugier commented on GitHub (Jan 16, 2021):

TheIDE is build-able again - closing issue...

<!-- gh-comment-id:761648602 --> @klugier commented on GitHub (Jan 16, 2021): TheIDE is build-able again - closing issue...
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#10
No description provided.