[GH-ISSUE #4] Removed properties of CommonFontInfo struct are referenced in XFtGetFontInfoSys() #1

Closed
opened 2026-05-05 03:32:59 -06:00 by gitea-mirror · 1 comment
Owner

Originally created by @ismail-yilmaz on GitHub (Oct 18, 2018).
Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/4

Hello,
Below properties (height, lineheight) had been removed from CommonFontInfo some time ago.
Yet they are still used in XFtGetFontInfoSys() function. This leads to a compiler error when the NOGTK mode is enabled.

cf97a1a31d/uppsrc/CtrlCore/DrawTextX11.cpp (L118-L119)

Originally created by @ismail-yilmaz on GitHub (Oct 18, 2018). Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/4 Hello, Below properties (height, lineheight) had been removed from CommonFontInfo some time ago. Yet they are still used in XFtGetFontInfoSys() function. This leads to a compiler error when the NOGTK mode is enabled. https://github.com/ultimatepp/mirror/blob/cf97a1a31dcbd81f0fd6e55925c6644be859acaf/uppsrc/CtrlCore/DrawTextX11.cpp#L118-L119
Author
Owner

@ismail-yilmaz commented on GitHub (Oct 23, 2018):

Fixed.
09efd77e66 (diff-4c061be033880ce04abf4012d79dba13)

<!-- gh-comment-id:432188738 --> @ismail-yilmaz commented on GitHub (Oct 23, 2018): Fixed. https://github.com/ultimatepp/mirror/commit/09efd77e6602e57f937bc96d5143e06934e95923#diff-4c061be033880ce04abf4012d79dba13
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#1
No description provided.