[PR #253] [README.md] improve code legibility #258

New issue

Open

opened 2026-05-05 11:21:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:21:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/253
Author: @kaixoo12
Created: 12/26/2025
Status: 🔄 Open

Base: develop ← Head: kaixoo12-readme

📝 Commits (1)

02ca8a1 docs: improve code legibility

📊 Changes

1 file changed (+7 additions, -10 deletions)

View changed files

📝 README.md (+7 -10)

📄 Description

Maybe this is a little hyperbolic, but I am a never nester so this code was a little bit hard to read for me.

If these types could return null or throw - which it doesn't seem they do - it would be better to place inverted if clauses.

var app = new QGuiApplication(args);
if (!app)
    // Handle exception
    return 1;
}
var engine = new QQmlApplicationEngine();
if (!engine) {
    // Handle exception
    return -1
}

// Application code
...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/253 **Author:** [@kaixoo12](https://github.com/kaixoo12) **Created:** 12/26/2025 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `kaixoo12-readme` --- ### 📝 Commits (1) - [`02ca8a1`](https://github.com/qmlnet/qmlnet/commit/02ca8a103afbd502fba895967b40928f1347cf59) docs: improve code legibility ### 📊 Changes **1 file changed** (+7 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+7 -10) </details> ### 📄 Description Maybe this is a little hyperbolic, but I am a [never nester](https://www.youtube.com/watch?v=CFRhGnuXG-4) so this code was a little bit hard to read for me. If these types could return null or throw - which it doesn't seem they do - it would be better to place *inverted if clauses*. ```csharp var app = new QGuiApplication(args); if (!app) // Handle exception return 1; } var engine = new QQmlApplicationEngine(); if (!engine) { // Handle exception return -1 } // Application code ... ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>