[PR #204] [MERGED] Fix Windows _UNICODE build #242

New issue

Closed

opened 2026-05-05 11:21:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:21:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/204
Author: @shartte
Created: 5/29/2020
Status: ✅ Merged
Merged: 5/30/2020
Merged by: @pauldotknopf

Base: develop ← Head: fix-win32-unicode-build

📝 Commits (1)

6d7eb7b Fix Windows _UNICODE build

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/native/QmlNet/Hosting/CoreHost.cpp (+1 -1)

📄 Description

Use charset specific variant of GetModuleHandle without relying
on _UNICODE not being defined.

Fixes #197

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/204 **Author:** [@shartte](https://github.com/shartte) **Created:** 5/29/2020 **Status:** ✅ Merged **Merged:** 5/30/2020 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `fix-win32-unicode-build` --- ### 📝 Commits (1) - [`6d7eb7b`](https://github.com/qmlnet/qmlnet/commit/6d7eb7bbb1a8afdedcd912f3608486db379a3aff) Fix Windows _UNICODE build ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/Hosting/CoreHost.cpp` (+1 -1) </details> ### 📄 Description Use charset specific variant of GetModuleHandle without relying on _UNICODE not being defined. Fixes #197 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>