[PR #203] [MERGED] Use QChar* instead of custom string typedefs #241

New issue

Closed

opened 2026-05-05 11:21:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:21:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/203
Author: @shartte
Created: 5/23/2020
Status: ✅ Merged
Merged: 5/26/2020
Merged by: @pauldotknopf

Base: develop ← Head: use-qchar

📝 Commits (1)

555ad31 Use QChar* instead of custom string typedefs

📊 Changes

18 files changed (+93 additions, -127 deletions)

View changed files

📝 src/native/QmlNet/QmlNet.h (+0 -31)
📝 src/native/QmlNet/QmlNet/qml/NetJsValue.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/qml/NetQObject.cpp (+13 -13)
📝 src/native/QmlNet/QmlNet/qml/NetTestHelper.cpp (+2 -2)
📝 src/native/QmlNet/QmlNet/qml/NetVariant.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/qml/QCommon.cpp (+2 -2)
📝 src/native/QmlNet/QmlNet/qml/QCoreApplication.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/qml/QLocaleInterop.cpp (+1 -1)
📝 src/native/QmlNet/QmlNet/qml/QQmlApplicationEngine.cpp (+21 -21)
📝 src/native/QmlNet/QmlNet/qml/QQuickStyle.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/qml/QResource.cpp (+6 -6)
📝 src/native/QmlNet/QmlNet/types/Callbacks.cpp (+12 -11)
📝 src/native/QmlNet/QmlNet/types/NetMethodInfo.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/types/NetPropertyInfo.cpp (+4 -4)
📝 src/native/QmlNet/QmlNet/types/NetReference.cpp (+2 -2)
📝 src/native/QmlNet/QmlNet/types/NetSignalInfo.cpp (+2 -2)
📝 src/native/QmlNet/QmlNet/types/NetTypeInfo.cpp (+6 -10)
📝 src/native/QmlNet/QmlNet/types/NetTypeManager.cpp (+2 -2)

📄 Description

Qt defines QChar as a class containing a ushort, which
should be consistently 16-bit across supported platforms.
this change uses QChar* instead of custom typedefs
to intepret LPWStr arguments passed to/from .NET.

See #190

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/203 **Author:** [@shartte](https://github.com/shartte) **Created:** 5/23/2020 **Status:** ✅ Merged **Merged:** 5/26/2020 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `use-qchar` --- ### 📝 Commits (1) - [`555ad31`](https://github.com/qmlnet/qmlnet/commit/555ad313d20a30b30bc67c9cfda0995b4574ae8e) Use QChar* instead of custom string typedefs ### 📊 Changes **18 files changed** (+93 additions, -127 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/QmlNet.h` (+0 -31) 📝 `src/native/QmlNet/QmlNet/qml/NetJsValue.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/qml/NetQObject.cpp` (+13 -13) 📝 `src/native/QmlNet/QmlNet/qml/NetTestHelper.cpp` (+2 -2) 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/qml/QCommon.cpp` (+2 -2) 📝 `src/native/QmlNet/QmlNet/qml/QCoreApplication.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/qml/QLocaleInterop.cpp` (+1 -1) 📝 `src/native/QmlNet/QmlNet/qml/QQmlApplicationEngine.cpp` (+21 -21) 📝 `src/native/QmlNet/QmlNet/qml/QQuickStyle.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/qml/QResource.cpp` (+6 -6) 📝 `src/native/QmlNet/QmlNet/types/Callbacks.cpp` (+12 -11) 📝 `src/native/QmlNet/QmlNet/types/NetMethodInfo.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/types/NetPropertyInfo.cpp` (+4 -4) 📝 `src/native/QmlNet/QmlNet/types/NetReference.cpp` (+2 -2) 📝 `src/native/QmlNet/QmlNet/types/NetSignalInfo.cpp` (+2 -2) 📝 `src/native/QmlNet/QmlNet/types/NetTypeInfo.cpp` (+6 -10) 📝 `src/native/QmlNet/QmlNet/types/NetTypeManager.cpp` (+2 -2) </details> ### 📄 Description Qt defines QChar as a class containing a ushort, which should be consistently 16-bit across supported platforms. this change uses QChar* instead of custom typedefs to intepret LPWStr arguments passed to/from .NET. See #190 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>