[PR #114] [MERGED] Let native callbacks be defined in shared libraries. #214

New issue

Closed

opened 2026-05-05 11:20:57 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:57 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/114
Author: @afillebrown
Created: 3/25/2019
Status: ✅ Merged
Merged: 4/10/2019
Merged by: @pauldotknopf

Base: develop ← Head: feature/enable-callbacks-in-shared-libraries

📝 Commits (3)

3ccc077 Let native callbacks be defined in shared libraries.
074ff2a Preserve nullptr if native module name is null or empty.
5efb489 Let native callbacks be defined in shared libraries on *nix platforms.

📊 Changes

2 files changed (+9 additions, -2 deletions)

View changed files

📝 src/native/QmlNet/Hosting/CoreHost.cpp (+8 -2)
📝 src/native/QmlNet/Hosting/CoreHost.h (+1 -0)

📄 Description

When using unmanaged hosting, callbacks are currently limited to the top-level executable. We would like to put the callbacks in a shared library, instead. This PR is a rough-draft that shows how I got it working on Windows. Please take a look and let me know if this is the right direction to take or if there's a better way. Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/114 **Author:** [@afillebrown](https://github.com/afillebrown) **Created:** 3/25/2019 **Status:** ✅ Merged **Merged:** 4/10/2019 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `feature/enable-callbacks-in-shared-libraries` --- ### 📝 Commits (3) - [`3ccc077`](https://github.com/qmlnet/qmlnet/commit/3ccc0774066ee173955342338eb2b07d7a622195) Let native callbacks be defined in shared libraries. - [`074ff2a`](https://github.com/qmlnet/qmlnet/commit/074ff2a09321a08ef573efe566ee8d6b91b8b2a2) Preserve nullptr if native module name is null or empty. - [`5efb489`](https://github.com/qmlnet/qmlnet/commit/5efb489fc619af95f2f25e7312293cd0ab1b9356) Let native callbacks be defined in shared libraries on *nix platforms. ### 📊 Changes **2 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/Hosting/CoreHost.cpp` (+8 -2) 📝 `src/native/QmlNet/Hosting/CoreHost.h` (+1 -0) </details> ### 📄 Description When using unmanaged hosting, callbacks are currently limited to the top-level executable. We would like to put the callbacks in a shared library, instead. This PR is a rough-draft that shows how I got it working on Windows. Please take a look and let me know if this is the right direction to take or if there's a better way. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>