[PR #97] [CLOSED] Add StyleCop for a more consistent code base. #210

New issue

Closed

opened 2026-05-05 11:20:52 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:52 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/97
Author: @MaxMommersteeg
Created: 12/24/2018
Status: ❌ Closed

Base: develop ← Head: feature/add-stylecop

📝 Commits (3)

7176335 Merge pull request #2 from qmlnet/develop
e9c9b60 Added StyleCop with a ruleset. Formatted code according to rules.
9244f58 Cleaned StyleCop reference in csprojs.

📊 Changes

76 files changed (+935 additions, -660 deletions)

View changed files

➕ StyleCop.ruleset (+115 -0)
📝 src/net/Qml.Net.Benchmarks/Config.cs (+1 -1)
📝 src/net/Qml.Net.Benchmarks/Qml.Net.Benchmarks.csproj (+14 -12)
📝 src/net/Qml.Net.Benchmarks/ReferenceBenchmarks.cs (+5 -6)
📝 src/net/Qml.Net.Sandbox/Program.UI.cs (+4 -4)
📝 src/net/Qml.Net.Sandbox/Qml.Net.Sandbox.csproj (+22 -20)
📝 src/net/Qml.Net.Tests/BaseTests.cs (+1 -1)
📝 src/net/Qml.Net.Tests/Internal/ObjectTaggerTests.cs (+9 -11)
📝 src/net/Qml.Net.Tests/MockTypeCreator.cs (+1 -1)
📝 src/net/Qml.Net.Tests/Qml.Net.Tests.csproj (+18 -16)
📝 src/net/Qml.Net.Tests/Qml/AwaitTests.cs (+3 -5)
📝 src/net/Qml.Net.Tests/Qml/BaseQmlTests.cs (+24 -17)
📝 src/net/Qml.Net.Tests/Qml/BoolTests.cs (+4 -6)
📝 src/net/Qml.Net.Tests/Qml/CharTests.cs (+5 -7)
📝 src/net/Qml.Net.Tests/Qml/DateTimeOffsetTests.cs (+4 -6)
📝 src/net/Qml.Net.Tests/Qml/DateTimeTests.cs (+3 -4)
📝 src/net/Qml.Net.Tests/Qml/DoubleTests.cs (+2 -3)
📝 src/net/Qml.Net.Tests/Qml/IntTests.cs (+2 -3)
📝 src/net/Qml.Net.Tests/Qml/JsValueTests.cs (+32 -39)
📝 src/net/Qml.Net.Tests/Qml/LifetimeTests.cs (+3 -4)

...and 56 more files

📄 Description

The current way of coding is a bit inconsistent on the formatting part. An analyzer like StyleCop could help us with that. I added a simple Ruleset file containing a few rules that will guide contributers in writing code in a similar manner.

Actual implementation has not changed. Not sure if we should merge this. Maybe the first thing to do is defining a good ruleset for this repository, if we want to do this at all.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/97 **Author:** [@MaxMommersteeg](https://github.com/MaxMommersteeg) **Created:** 12/24/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `feature/add-stylecop` --- ### 📝 Commits (3) - [`7176335`](https://github.com/qmlnet/qmlnet/commit/71763351663268eaa57b4524e8dcda8be8b3e886) Merge pull request #2 from qmlnet/develop - [`e9c9b60`](https://github.com/qmlnet/qmlnet/commit/e9c9b6041bc7bcd37c71f74c1c0d2e9496af039f) Added StyleCop with a ruleset. Formatted code according to rules. - [`9244f58`](https://github.com/qmlnet/qmlnet/commit/9244f5824fb2585e6f1832ce061efe1a11df06e2) Cleaned StyleCop reference in csprojs. ### 📊 Changes **76 files changed** (+935 additions, -660 deletions) <details> <summary>View changed files</summary> ➕ `StyleCop.ruleset` (+115 -0) 📝 `src/net/Qml.Net.Benchmarks/Config.cs` (+1 -1) 📝 `src/net/Qml.Net.Benchmarks/Qml.Net.Benchmarks.csproj` (+14 -12) 📝 `src/net/Qml.Net.Benchmarks/ReferenceBenchmarks.cs` (+5 -6) 📝 `src/net/Qml.Net.Sandbox/Program.UI.cs` (+4 -4) 📝 `src/net/Qml.Net.Sandbox/Qml.Net.Sandbox.csproj` (+22 -20) 📝 `src/net/Qml.Net.Tests/BaseTests.cs` (+1 -1) 📝 `src/net/Qml.Net.Tests/Internal/ObjectTaggerTests.cs` (+9 -11) 📝 `src/net/Qml.Net.Tests/MockTypeCreator.cs` (+1 -1) 📝 `src/net/Qml.Net.Tests/Qml.Net.Tests.csproj` (+18 -16) 📝 `src/net/Qml.Net.Tests/Qml/AwaitTests.cs` (+3 -5) 📝 `src/net/Qml.Net.Tests/Qml/BaseQmlTests.cs` (+24 -17) 📝 `src/net/Qml.Net.Tests/Qml/BoolTests.cs` (+4 -6) 📝 `src/net/Qml.Net.Tests/Qml/CharTests.cs` (+5 -7) 📝 `src/net/Qml.Net.Tests/Qml/DateTimeOffsetTests.cs` (+4 -6) 📝 `src/net/Qml.Net.Tests/Qml/DateTimeTests.cs` (+3 -4) 📝 `src/net/Qml.Net.Tests/Qml/DoubleTests.cs` (+2 -3) 📝 `src/net/Qml.Net.Tests/Qml/IntTests.cs` (+2 -3) 📝 `src/net/Qml.Net.Tests/Qml/JsValueTests.cs` (+32 -39) 📝 `src/net/Qml.Net.Tests/Qml/LifetimeTests.cs` (+3 -4) _...and 56 more files_ </details> ### 📄 Description The current way of coding is a bit inconsistent on the formatting part. An analyzer like StyleCop could help us with that. I added a simple Ruleset file containing a few rules that will guide contributers in writing code in a similar manner. Actual implementation has not changed. Not sure if we should merge this. Maybe the first thing to do is defining a good ruleset for this repository, if we want to do this at all. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>