[PR #105] [MERGED] Cached dynamic delegates for perf increase. #208

New issue

Closed

opened 2026-05-05 11:20:51 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:51 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/105
Author: @pauldotknopf
Created: 2/18/2019
Status: ✅ Merged
Merged: 2/18/2019
Merged by: @pauldotknopf

Base: develop ← Head: cached-dels

📝 Commits (1)

db701da Cached delegates for perf increases.

📊 Changes

11 files changed (+503 additions, -251 deletions)

View changed files

📝 src/native/QmlNet/QmlNet/types/NetPropertyInfo.cpp (+36 -0)
📝 src/native/QmlNet/QmlNet/types/NetPropertyInfo.h (+5 -0)
📝 src/net/Qml.Net.Tests/CodeGen/CodeGenParameterTests.cs (+59 -0)
📝 src/net/Qml.Net.Tests/CodeGen/CodeGenPropertyTests.cs (+137 -4)
📝 src/net/Qml.Net.Tests/CodeGen/CodeGenReturnTypeTests.cs (+59 -0)
📝 src/net/Qml.Net.Tests/Types/NetTypeManagerTests.cs (+24 -0)
📝 src/net/Qml.Net/Internal/CodeGen/CodeGen.Methods.cs (+1 -9)
📝 src/net/Qml.Net/Internal/CodeGen/CodeGen.cs (+63 -130)
📝 src/net/Qml.Net/Internal/DefaultCallbacks.cs (+39 -108)
📝 src/net/Qml.Net/Internal/Qml/NetVariant.cs (+39 -0)
📝 src/net/Qml.Net/Internal/Types/NetPropertyInfo.cs (+41 -0)

📄 Description

Closes #39.

I haven't don't benchmarks, but this will likely lead to big perf increases. Reflection is used to build the delegates, but after the delegates are built/used, reflection isn't touched.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/105 **Author:** [@pauldotknopf](https://github.com/pauldotknopf) **Created:** 2/18/2019 **Status:** ✅ Merged **Merged:** 2/18/2019 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `cached-dels` --- ### 📝 Commits (1) - [`db701da`](https://github.com/qmlnet/qmlnet/commit/db701da9ec229a22cb7adfab2fe705f020ff5341) Cached delegates for perf increases. ### 📊 Changes **11 files changed** (+503 additions, -251 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/QmlNet/types/NetPropertyInfo.cpp` (+36 -0) 📝 `src/native/QmlNet/QmlNet/types/NetPropertyInfo.h` (+5 -0) 📝 `src/net/Qml.Net.Tests/CodeGen/CodeGenParameterTests.cs` (+59 -0) 📝 `src/net/Qml.Net.Tests/CodeGen/CodeGenPropertyTests.cs` (+137 -4) 📝 `src/net/Qml.Net.Tests/CodeGen/CodeGenReturnTypeTests.cs` (+59 -0) 📝 `src/net/Qml.Net.Tests/Types/NetTypeManagerTests.cs` (+24 -0) 📝 `src/net/Qml.Net/Internal/CodeGen/CodeGen.Methods.cs` (+1 -9) 📝 `src/net/Qml.Net/Internal/CodeGen/CodeGen.cs` (+63 -130) 📝 `src/net/Qml.Net/Internal/DefaultCallbacks.cs` (+39 -108) 📝 `src/net/Qml.Net/Internal/Qml/NetVariant.cs` (+39 -0) 📝 `src/net/Qml.Net/Internal/Types/NetPropertyInfo.cs` (+41 -0) </details> ### 📄 Description Closes #39. I haven't don't benchmarks, but this will likely lead to big perf increases. Reflection is used to build the delegates, but after the delegates are built/used, reflection isn't touched. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>