mirror of
https://github.com/qmlnet/qmlnet.git
synced 2026-05-15 14:15:54 -06:00
[GH-ISSUE #43] Remove AdvanceDLSupport from project. #20
Labels
No labels
bug
enhancement
help wanted
help wanted
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/qmlnet#20
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pauldotknopf on GitHub (Aug 2, 2018).
Original GitHub issue: https://github.com/qmlnet/qmlnet/issues/43
It is great and all, but we aren't using all the features of it. The only thing we get from it is the ability to have a single PInvoke/DllImport for each assembly. We could implement this ourselves by emitting custom classes with os-specific DllImport attributes.
Also, the every project the references
Qml.Netadds multiple files in the root.@Nihlus commented on GitHub (Aug 9, 2018):
I've been on vacation and haven't had time to address the issue with the external annotation files. I'd expect to be able to fix that during next week.
@Nihlus commented on GitHub (Aug 10, 2018):
Found some time - the issue is now fixed.
@MaxMommersteeg commented on GitHub (Dec 24, 2018):
This one is fixed right?
6ace3a1bb7@Nihlus commented on GitHub (Dec 24, 2018):
@MaxMommersteeg At the moment, there's a licensing issue with the new library that Qml.NET uses, since it's copied large portions of code directly from ADL without retaining the LGPL license or the copyright notice.
@TripleWhy commented on GitHub (Dec 24, 2018):
@pauldotknopf This is a serious issue. Right now I would not use qml.net in a commercial application due to this and this licensing uncertainties.
@Perksey commented on GitHub (Dec 24, 2018):
Qml.NET needs to stop using the other lib as it’s technically illegal, and I wouldn’t want to be affected by copyright disputes. Plus half of the issue is fixed in ADL now.
I ask that you revert the commit in which the library was replaced. I also advise on adding a PrivateAssets entry on the PackageReference to prevent unneeded redistribution, similar to the one added in ADL with StrictEmit.
@pauldotknopf commented on GitHub (Dec 24, 2018):
I've re-licences NetNativeLibLoader, so there shouldn't be any issues anymore.
And yes, @MaxMommersteeg, this issue is now resolved. Thanks for linting the issues for me.